From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AB9D5C433EF for ; Mon, 28 Feb 2022 01:04:40 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F3C3310E1F7; Mon, 28 Feb 2022 01:04:39 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) by gabe.freedesktop.org (Postfix) with ESMTPS id F222910E1F7 for ; Mon, 28 Feb 2022 01:04:37 +0000 (UTC) Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id A2F9B83A45; Mon, 28 Feb 2022 02:04:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1646010276; bh=OJNMnUVNafU61yaAHKLvz4SdZo43KUrxCkhls87bHnM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=A/cQxmUOCwoMiKgPmxfpfZVzIVKnk7z0GlLFOq2xH1otWtFAZXTLuqINcUDQ9I/VU fYeqCB1r156xFXY05NqawtQptAYOgACtMn6l6cPQ1fBz+CLoQdfavU2PtQt0FnXSA0 +rJNJGpoTG8iUDsEmSYqYfupwfCVYH99gJjEqhglPGtDWm1P/A35Eonj8d2wZeqOqa Ns0t4r3zH+1Fnoi6ohM5lOisuYaO9vZX848HCmQTpi6e8YYoExNGHpC8PyzDqw0aC7 cOvN6pDaUVDUUKs6fsuPvZSbZpuYiMfLwPXkluPZSVj4lIKK84mqEhR6Upz1lfwpcB iPtQbYRauoSNA== Message-ID: <4be01be7-decb-881c-ec3d-fb583feaed35@denx.de> Date: Mon, 28 Feb 2022 02:04:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH V2] drm/imx: parallel-display: Remove bus flags check in imx_pd_bridge_atomic_check() Content-Language: en-US To: Boris Brezillon , Max Krummenacher References: <20220201113643.4638-1-cniedermaier@dh-electronics.com> <36f517300a15b2460a02512ef3c5814ad0ed2290.camel@gmail.com> <20220221092908.6d8d18c5@collabora.com> <20220221133141.06171584@collabora.com> From: Marek Vasut In-Reply-To: <20220221133141.06171584@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Christoph Niedermaier , "Marek MV. Vasut\"" , David Airlie , Sascha Hauer , "dri-devel@lists.freedesktop.org" , NXP Linux Team , Pengutronix Kernel Team , Shawn Guo , "linux-arm-kernel@lists.infradead.org\"" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 2/21/22 13:31, Boris Brezillon wrote: > On Mon, 21 Feb 2022 12:56:43 +0100 > Max Krummenacher wrote: > >> Am Montag, den 21.02.2022, 09:29 +0100 schrieb Boris Brezillon: >>> Hello Christoph, >>> >>> On Sat, 19 Feb 2022 09:28:44 +0000 >>> Christoph Niedermaier wrote: >>> >>>> From: Max Krummenacher [mailto:max.oss.09@gmail.com] >>>> Sent: Wednesday, February 9, 2022 10:38 AM >>>>>> If display timings were read from the devicetree using >>>>>> of_get_display_timing() and pixelclk-active is defined >>>>>> there, the flag DISPLAY_FLAGS_SYNC_POSEDGE/NEGEDGE is >>>>>> automatically generated. Through the function >>>>>> drm_bus_flags_from_videomode() e.g. called in the >>>>>> panel-simple driver this flag got into the bus flags, >>>>>> but then in imx_pd_bridge_atomic_check() the bus flag >>>>>> check failed and will not initialize the display. The >>>>>> original commit fe141cedc433 does not explain why this Can you please update the commit message to fix the following warning: Please use git commit description style 'commit <12+ chars of sha1> ("")' - ie: 'commit fe141cedc433 ("drm/imx: pd: Use bus format/flags provided by the bridge when available")' Also, collect the AB from Boris and TB from Max. I can also fix it up for you while applying if that's OK with you. [...] > Acked-by: Boris Brezillon <boris.brezillon@collabora.com> [...]