From mboxrd@z Thu Jan 1 00:00:00 1970 From: Archit Taneja Subject: Re: [PATCH] gpu: drm: bridge: adv7511: Replace mdelay with usleep_range in adv7511_probe Date: Fri, 4 May 2018 11:38:46 +0530 Message-ID: <4cc08136-b05f-89d9-6e6f-dcd12ebc86d3@codeaurora.org> References: <1523435622-4329-1-git-send-email-baijiaju1990@gmail.com> <5009396.5p49gfLLAe@avalon> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5009396.5p49gfLLAe@avalon> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Laurent Pinchart , Jia-Ju Bai Cc: a.hajda@samsung.com, airlied@linux.ie, daniel.vetter@ffwll.ch, bhumirks@gmail.com, narmstrong@baylibre.com, inki.dae@samsung.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org On Friday 27 April 2018 03:46 AM, Laurent Pinchart wrote: > Hi Jia-Ju, > > Thank you for the patch. > > On Wednesday, 11 April 2018 11:33:42 EEST Jia-Ju Bai wrote: >> adv7511_probe() is never called in atomic context. >> This function is only set as ".probe" in struct i2c_driver. >> >> Despite never getting called from atomic context, adv7511_probe() >> calls mdelay() to busily wait. >> This is not necessary and can be replaced with usleep_range() to >> avoid busy waiting. >> >> This is found by a static analysis tool named DCNS written by myself. >> And I also manually check it. > > Nice work ! Is the tool open-source ? > >> Signed-off-by: Jia-Ju Bai >> --- >> drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c >> b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c index b2431ae..2cf7fa1 >> 100644 >> --- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c >> +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c >> @@ -1054,7 +1054,7 @@ static int adv7511_probe(struct i2c_client *i2c, const >> struct i2c_device_id *id) } >> >> if (adv7511->gpio_pd) { >> - mdelay(5); >> + usleep_range(5000, 6000); >> gpiod_set_value_cansleep(adv7511->gpio_pd, 0); >> } > > The patch looks good to me. > > Reviewed-by: Laurent Pinchart queued to drm-misc-next Thanks, Archit