Re: [PATCH 1/3] drm/exynos: mixer: add 2x scaling to mixer_graph_buffer

[Tobias Jakobi <tjakobi@math.uni-bielefeld.de>]

Hello Gustavo,

On 2015-03-27 14:11, Gustavo Padovan wrote:
> If you can rebase this in on top of my series this would be really 
> good.
like I said in my other mail, the series doesn't apply cleanly anymore, 
so I had to rebase your series.


>> Then it would just be:
>> static int mixer_setup_scale(const struct exynos_drm_plane *plane,
>> 	unsigned int *x_ratio, unsigned int *y_ratio)
>> 
>> Also that would automatically fix your other comment below [*].
>> 
>> 
>> > Use EPERM or ENOTSUPP. Or even true/false.
>> Will do!
>> 
>> 
>> > You need to fix style here
>> >
>> >         if (mixer_setup_scale(win_data->src_width, win_data->src_height,
>> >                               win_data->crtc_width, win_data->crtc_height,
>> >                               &x_ratio, &y_ratio))
>> >                 return;
>> With [*] this would just be:
>> if (mixer_setup_scale(plane, &x_ratio, &y_ratio)) return;
>> 
>> What do you think?
> 
> Changes sounds good to me. Please go ahead and send a new patch. :)
I've integrated the changes and just sent it out together with two other 
small fixes.

Here's the important part:
https://patchwork.kernel.org/patch/6140451/


With best wishes,
Tobias