From: Nirmoy <nirmodas@amd.com>
To: "Christian König" <ckoenig.leichtzumerken@gmail.com>,
dri-devel@lists.freedesktop.org
Cc: ray.huang@amd.com, matthew.william.auld@gmail.com
Subject: Re: [PATCH 1/3] drm/ttm: move swapout logic around v2
Date: Thu, 18 Mar 2021 20:46:43 +0100 [thread overview]
Message-ID: <4ef57ca5-0865-043e-cb31-787a66c93b8d@amd.com> (raw)
In-Reply-To: <dcbdef7a-d18d-c729-0e8a-bfe562b64695@gmail.com>
On 3/18/21 4:26 PM, Christian König wrote:
> Am 18.03.21 um 15:43 schrieb Nirmoy:
>> Hi Christian,
>>
>> On 3/18/21 1:47 PM, Christian König wrote:
>> <snip>
>>> /**
>>> * ttm_bo_uses_embedded_gem_object - check if the given bo uses the
>>> diff --git a/include/drm/ttm/ttm_device.h
>>> b/include/drm/ttm/ttm_device.h
>>> index 035bbc044a3b..6a0b267d4fe6 100644
>>> --- a/include/drm/ttm/ttm_device.h
>>> +++ b/include/drm/ttm/ttm_device.h
>>> @@ -297,6 +297,8 @@ struct ttm_device {
>>> struct delayed_work wq;
>>> };
>>> +long ttm_global_swapout(struct ttm_operation_ctx *ctx, gfp_t
>>> gfp_flags);
>>
>>
>> There is a typo here, long -> int.
>
> Ah, yes. I missed to add the change to the header file.
I have tested the patch series on qxl and vmwgfx.
With that typo fixed, the series is Tested-by: Nirmoy Das
<nirmoy.das@amd.com>
>
> Thanks for pointing that out,
> Christian.
>
>>
>>
>> Thanks,
>>
>> Nirmoy
>>
>>
>>> +
>>> static inline struct ttm_resource_manager *
>>> ttm_manager_type(struct ttm_device *bdev, int mem_type)
>>> {
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2021-03-18 19:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-18 12:47 [PATCH 1/3] drm/ttm: move swapout logic around v2 Christian König
2021-03-18 12:47 ` [PATCH 2/3] drm/ttm: remove swap LRU v3 Christian König
2021-03-19 4:30 ` Huang Rui
2021-03-18 12:47 ` [PATCH 3/3] drm/ttm: switch to per device LRU lock Christian König
2021-03-19 4:32 ` Huang Rui
2021-03-19 12:10 ` Christian König
2021-03-22 7:13 ` Huang Rui
2021-03-18 14:43 ` [PATCH 1/3] drm/ttm: move swapout logic around v2 Nirmoy
2021-03-18 15:26 ` Christian König
2021-03-18 19:46 ` Nirmoy [this message]
2021-03-18 15:08 ` kernel test robot
2021-03-18 18:13 ` kernel test robot
2021-03-19 12:07 ` Christian König
2021-03-19 4:28 ` Huang Rui
2021-03-19 9:41 ` Matthew Auld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ef57ca5-0865-043e-cb31-787a66c93b8d@amd.com \
--to=nirmodas@amd.com \
--cc=ckoenig.leichtzumerken@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=matthew.william.auld@gmail.com \
--cc=ray.huang@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox