From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1431AC433EF for ; Thu, 13 Jan 2022 12:57:54 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 45A8410FB51; Thu, 13 Jan 2022 12:57:54 +0000 (UTC) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id F031410FB4B for ; Thu, 13 Jan 2022 12:57:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642078672; x=1673614672; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=iycjm2C+Mf7QsOANPLMYnMeG7Nklub2C0BsuRJJMnhc=; b=ni5R2nlehrpoAQSDhBaLinXVBoWcMIMrR6nHCJElpinvysZ8Ei5K0wC5 7UpeCUvCEXieHLxWDk3rWvLluJSLU7x9kzPo/3W/EJT7QUMNjyvpcDXgh Uv3NAtwjK5sssAdk2HMIZsZeWk2y1zCiKPcSHR2VVmHmvAto60dt0XOmU I+fBrec6SCgvGlpECOEUfmdGum6Je5BriZR+Ux80HTJqUR95dDA5crKiT TKmEqNVUqsvWCOj0FQihnEE6yxrloDAWGG8/TVg8USsci7e+Gz+lBv1vt MwJQ09PGKvYjE9ttlTP39RylZCmm+iHHdY3CY0QQmj9NBMi9NZzO6MvM1 w==; X-IronPort-AV: E=McAfee;i="6200,9189,10225"; a="224690091" X-IronPort-AV: E=Sophos;i="5.88,286,1635231600"; d="scan'208";a="224690091" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jan 2022 04:57:52 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,286,1635231600"; d="scan'208";a="691791936" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by orsmga005.jf.intel.com with ESMTP; 13 Jan 2022 04:57:52 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 13 Jan 2022 04:57:51 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 13 Jan 2022 04:57:51 -0800 Received: from orsmsx611.amr.corp.intel.com ([10.22.229.24]) by ORSMSX611.amr.corp.intel.com ([10.22.229.24]) with mapi id 15.01.2308.020; Thu, 13 Jan 2022 04:57:51 -0800 From: "Ruhl, Michael J" To: "guangming.cao@mediatek.com" , "sumit.semwal@linaro.org" Subject: RE: [PATCH v3] dma-buf: dma-heap: Add a size check for allocation Thread-Topic: [PATCH v3] dma-buf: dma-heap: Add a size check for allocation Thread-Index: AQHYCHnKJjUnVmCmlECrXD1d8qRuLKxg6T0Q Date: Thu, 13 Jan 2022 12:57:51 +0000 Message-ID: <4f88205c1b344aea8608960e2f85b8f4@intel.com> References: <20220113123406.11520-1-guangming.cao@mediatek.com> In-Reply-To: <20220113123406.11520-1-guangming.cao@mediatek.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 x-originating-ip: [10.1.200.100] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "jianjiao.zeng@mediatek.com" , "lmark@codeaurora.org" , "wsd_upstream@mediatek.com" , "christian.koenig@amd.com" , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "yf.wang@mediatek.com" , "linaro-mm-sig@lists.linaro.org" , "linux-mediatek@lists.infradead.org" , "libo.kang@mediatek.com" , "benjamin.gaignard@linaro.org" , "bo.song@mediatek.com" , "matthias.bgg@gmail.com" , "labbott@redhat.com" , "mingyuan.ma@mediatek.com" , "linux-arm-kernel@lists.infradead.org" , "linux-media@vger.kernel.org" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" >-----Original Message----- >From: dri-devel On Behalf Of >guangming.cao@mediatek.com >Sent: Thursday, January 13, 2022 7:34 AM >To: sumit.semwal@linaro.org >Cc: linux-arm-kernel@lists.infradead.org; mingyuan.ma@mediatek.com; >Guangming ; >wsd_upstream@mediatek.com; linux-kernel@vger.kernel.org; dri- >devel@lists.freedesktop.org; linaro-mm-sig@lists.linaro.org; >yf.wang@mediatek.com; libo.kang@mediatek.com; >benjamin.gaignard@linaro.org; bo.song@mediatek.com; >matthias.bgg@gmail.com; linux-mediatek@lists.infradead.org; >lmark@codeaurora.org; labbott@redhat.com; christian.koenig@amd.com; >jianjiao.zeng@mediatek.com; linux-media@vger.kernel.org >Subject: [PATCH v3] dma-buf: dma-heap: Add a size check for allocation > >From: Guangming > >Add a size check for allocation since the allocation size is >always less than the total DRAM size. > >Without this check, once the invalid size allocation runs on a process tha= t >can't be killed by OOM flow(such as "gralloc" on Android devices), it will >cause a kernel exception, and to make matters worse, we can't find who are >using >so many memory with "dma_buf_debug_show" since the relevant dma-buf >hasn't exported. > >To make OOM issue easier, maybe need dma-buf framework to dump the >buffer size >under allocating in "dma_buf_debug_show". > >Signed-off-by: Guangming >Signed-off-by: jianjiao zeng >--- >v3: 1. update patch, use right shift to replace division. > 2. update patch, add reason in code and commit message. >v2: 1. update size limitation as total_dram page size. > 2. update commit message >--- > drivers/dma-buf/dma-heap.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > >diff --git a/drivers/dma-buf/dma-heap.c b/drivers/dma-buf/dma-heap.c >index 56bf5ad01ad5..1fd382712584 100644 >--- a/drivers/dma-buf/dma-heap.c >+++ b/drivers/dma-buf/dma-heap.c >@@ -55,6 +55,16 @@ static int dma_heap_buffer_alloc(struct dma_heap >*heap, size_t len, > struct dma_buf *dmabuf; > int fd; > >+ /* >+ * Invalid size check. The "len" should be less than totalram. >+ * >+ * Without this check, once the invalid size allocation runs on a proces= s >that >+ * can't be killed by OOM flow(such as "gralloc" on Android devices), it >will >+ * cause a kernel exception, and to make matters worse, we can't find >who are using >+ * so many memory with "dma_buf_debug_show" since the relevant >dma-buf hasn't exported. >+ */ >+ if (len >> PAGE_SHIFT > totalram_pages()) If your "heap" is from cma, is this still a valid check? M >+ return -EINVAL; > /* > * Allocations from all heaps have to begin > * and end on page boundaries. >-- >2.17.1