From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robert Beckett Subject: Re: [PATCH] drm/imx: correct order of crtc disable Date: Thu, 20 Jun 2019 12:12:13 +0100 Message-ID: <4fceab36a9d800249b66bfd37114d63fc3386d29.camel@collabora.com> References: <20190618155003.18499-1-bob.beckett@collabora.com> <1560937217.2398.1.camel@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4504E6E3B4 for ; Thu, 20 Jun 2019 11:12:17 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter , Philipp Zabel Cc: dri-devel List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCAyMDE5LTA2LTIwIGF0IDEwOjUwICswMjAwLCBEYW5pZWwgVmV0dGVyIHdyb3RlOgo+ IE9uIFdlZCwgSnVuIDE5LCAyMDE5IGF0IDExOjQwIEFNIFBoaWxpcHAgWmFiZWwgPAo+IHAuemFi ZWxAcGVuZ3V0cm9uaXguZGU+IHdyb3RlOgo+ID4gCj4gPiBIaSBSb2JlcnQsCj4gPiAKPiA+IHRo YW5rIHlvdSBmb3IgdGhlIHBhdGNoLgo+ID4gCj4gPiBPbiBUdWUsIDIwMTktMDYtMTggYXQgMTY6 NTAgKzAxMDAsIFJvYmVydCBCZWNrZXR0IHdyb3RlOgo+ID4gPiBOb3RpZnkgZHJtIGNvcmUgYmVm b3JlIHNlbmRpbmcgcGVuZGluZyBldmVudHMgZHVyaW5nIGNydGMKPiA+ID4gZGlzYWJsZS4KPiA+ ID4gVGhpcyBmaXhlcyB0aGUgZmlyc3QgZXZlbnQgYWZ0ZXIgZGlzYWJsZSBoYXZpbmcgYW4gb2xk IHN0YWxlCj4gPiA+IHRpbWVzdGFtcAo+ID4gPiBieSBoYXZpbmcgZHJtX2NydGNfdmJsYW5rX29m ZiB1cGRhdGUgdGhlIHRpbWVzdGFtcCB0byBub3cuCj4gPiA+IAo+ID4gPiBUaGlzIHdhcyBzZWVu IHdoaWxlIGRlYnVnZ2luZyB3ZXN0b24gbG9nIG1lc3NhZ2U6Cj4gPiA+IFdhcm5pbmc6IGNvbXB1 dGVkIHJlcGFpbnQgZGVsYXkgaXMgaW5zYW5lOiAtODIxMiBtc2VjCj4gPiA+IAo+ID4gCj4gPiBX b3VsZCB5b3Ugc2F5IHRoaXMKPiA+IEZpeGVzOiBhNDc0NDc4NjQyZDUgKCJkcm0vaW14OiBmaXgg Y3J0YyB2Ymxhbmsgc3RhdGUgcmVncmVzc2lvbiIpCj4gPiA/Cj4gPiAKPiA+ID4gU2lnbmVkLW9m Zi1ieTogUm9iZXJ0IEJlY2tldHQgPGJvYi5iZWNrZXR0QGNvbGxhYm9yYS5jb20+Cj4gPiA+IC0t LQo+ID4gPiAgZHJpdmVycy9ncHUvZHJtL2lteC9pcHV2My1jcnRjLmMgfCA2ICsrKy0tLQo+ID4g PiAgMSBmaWxlIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKPiA+ID4g Cj4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaW14L2lwdXYzLWNydGMuYwo+ID4g PiBiL2RyaXZlcnMvZ3B1L2RybS9pbXgvaXB1djMtY3J0Yy5jCj4gPiA+IGluZGV4IDljYzFkNjc4 Njc0Zi4uYzQzNmEyOGQ1MGU0IDEwMDY0NAo+ID4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaW14 L2lwdXYzLWNydGMuYwo+ID4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaW14L2lwdXYzLWNydGMu Ywo+ID4gPiBAQCAtOTEsMTQgKzkxLDE0IEBAIHN0YXRpYyB2b2lkIGlwdV9jcnRjX2F0b21pY19k aXNhYmxlKHN0cnVjdAo+ID4gPiBkcm1fY3J0YyAqY3J0YywKPiA+ID4gICAgICAgaXB1X2RjX2Rp c2FibGUoaXB1KTsKPiA+ID4gICAgICAgaXB1X3ByZ19kaXNhYmxlKGlwdSk7Cj4gPiA+IAo+ID4g PiArICAgICBkcm1fY3J0Y192Ymxhbmtfb2ZmKGNydGMpOwo+ID4gPiArCj4gPiAKPiA+IFRoaXMg aXMgZXhwbGFpbmVkIGluIHRoZSBjb21taXQgbWVzc2FnZSBhbmQgYWxpZ25zIHdpdGggdGhlCj4g PiBkcm1fY3J0Y19zdGF0ZSBAZXZlbnQgZG9jdW1lbnRhdGlvbi4KPiAKPiBUaGlzIHBhcnQgaGVy ZSBsb29rcyBmaXNoeS4gVGhlIGRybV92YmxhbmsuYyBjb2RlIGlzIHN1cHBvc2VkIHRvIGRvCj4g dGhlIHJpZ2h0IHRoaW5nLCBubyBtYXR0ZXIgd2hlcmUgb3Igd2hlbiB5b3UgYXNrIGl0IHRvIGdl bmVyYXRlIGFuCj4gZXZlbnQuIEl0IGRlZmluaXRlbHkgc2hvdWxkbid0IGdlbmVyYXRlIGEgdGlt ZXN0YW1wIHRoYXQncyBhIGZldwo+IHNlY29uZHMgdG9vIGVhcmx5LiBCdW5jaCBvZiBvcHRpb25z Ogo+IC0gdGhlcmUncyBhIGJ1ZyBpbiBkcm1fdmJsYW5rLmMgYW5kIGl0J3MgbWl4aW5nIHVwIHNv bWV0aGluZyBhbmQKPiBnZW5lcmF0aW5nIGEgdG90YWxseSBib2d1cyB2YWx1ZS4KPiAtIHRoZXJl J3MgYSBsaWUgaW4geW91ciBpbXggdmJsYW5rIGNvZGUsIHdoaWNoIHRyaXBzIHRoZSBkcm1fdmJs YW5rLmMKPiBjb3VudGVyIGludGVycG9sYXRpb24gYW5kIHJlc3VsdHMgaW4gYSB0b3RhbGx5IGJv Z3VzIHZhbHVlLgo+IAo+IGRybV92YmxhbmsuYyBhc3N1bWVzIHRoYXQgaWYgeW91IGRvIGNsYWlt IHRvIGhhdmUgYSBodyBjb3VudGVyIGFuZAo+IGdlbmVyYXRlIHRpbWVzdGFtcHMsIHRoYXQgdGhv c2UgYXJlIHBlcmZlY3RseSBhY2N1cmF0ZS4gSXQgb25seSBmYWxscwo+IGJhY2sgdG8gZ3Vlc3Rp bWF0aW5nIHVzaW5nIHRoZSBzeXN0ZW0gdGltZXIgaWYgdGhhdCdzIG5vdCBwcmVzZW50Lgo+IAo+ IEVpdGhlciB3YXksIHRoaXMgdmVyeSBtdWNoIHNtZWxscyBsaWtlIHBhcGVyaW5nIG92ZXIgYSBi dWcgaWYgdGhpcwo+IGNoYW5nZSBpbmRlZWQgZml4ZXMgeW91ciB3cm9uZyB2YmxhbmsgdGltZXN0 YW1wcy4KPiAKCkEgcXVpY2sgZXhwbGFpbmF0aW9uIG9mIHdoZXJlIHRoZSBkb2RneSB0aW1lc3Rh bXAgY2FtZSBmcm9tOgoxLiBkcml2ZXIgc3RhcnRzIHVwCjIuIGZiY29uIGNvbWVzIGFsb25nIGFu ZCByZXN0b3JlcyBmYmRldiwgZW5hYmxpbmcgdmJsYW5rCjMuIHZibGFua19kaXNhYmxlX2ZuIGZp cmVzIHZpYSB0aW1lciBkaXNhYmxpbmcgdmJsYW5rLCBrZWVwaW5nIHZibGFuawpzZXEgbnVtYmVy IGFuZCB0aW1lIHNldCBhdCBjdXJyZW50IHZhbHVlCihzb21lIHRpbWUgbGF0ZXIpCjQuIHdlc3Rv biBzdGFydHMgYW5kIGRvZXMgYSBtb2Rlc2V0CjUuIGF0b21pYyBjb21taXQgZGlzYWJsZXMgY3J0 YyB3aGlsZSBpdCBkb2VzIHRoZSBtb2Rlc2V0CjYuIGlwdV9jcnRjX2F0b21pY19kaXNhYmxlIHNl bmRzIHZibGFuayB3aXRoIG9sZCBzZXEgbnVtYmVyIGFuZCB0aW1lCgpJdCB0dXJucyBvdXQgdGhl IGFjdHVhbCBmaXggZm9yIHRoZSBvbGQgdmJsYW5rIGlzIHRoZSBuZXh0IGNoYW5nZSwKd2hpY2gg c3RvcHMgaXQgYmVpbmcgc2VudCBhdCBhbGwgZHVyaW5nIHRoZSBjcnRjIGRpc2FibGUgYXMgaXQg aXMgaXMKc3RpbGwgYWN0aXZlLCBpdCB3b3VsZCB0aGVuIGdvIHRocm91Z2ggZHJtX2NydGNfdmJs YW5rX29mZiwgcmVzZXRpbmcKdGhlIHRpbWVzdGFtcCwgYW5kIGdldCBkZWxpdmVyZWQgZHVyaW5n IHRoZSB2YmxhbmsgZW5hYmxlIGFzIHBhcnQgb2YKdGhlIGF0b21pYyBjb21taXQuCgpTbywgaW4g dGhlb3J5LCB3ZSBjb3VsZCBqdXN0IGhhdmUgdGhlIGZvbGxvd2luZyBjaGFuZ2UgdG8gZml4IHRo ZQpzcGVjaWZpYyBpc3N1ZSBvZiBhIHN0YWxlIHRpbWVzdGFtcC4KCkhvd2V2ZXIsIGdpdmVuIHRo ZSBkb2N1bWVudGF0aW9uIGZvciB0aGUgZXZlbnQgaW4KaW5jbHVkZS9kcm0vZHJtX2NydGMuaDoK CiAgICAgICAgICogIC0gVGhlIGV2ZW50IGlzIGZvciBhIENSVEMgd2hpY2ggaXMgYmVpbmcgZGlz YWJsZWQgdGhyb3VnaAp0aGlzCiAgICAgICAgICogICAgYXRvbWljIGNvbW1pdC4gSW4gdGhhdCBj YXNlIHRoZSBldmVudCBjYW4gYmUgc2VuZCBvdXQgYW55CnRpbWUKICAgICAgICAgKiAgICBhZnRl ciB0aGUgaGFyZHdhcmUgaGFzIHN0b3BwZWQgc2Nhbm5pbmcgb3V0IHRoZSBjdXJyZW50CiAgICAg ICAgICogICAgZnJhbWVidWZmZXJzLiBJdCBzaG91bGQgY29udGFpbiB0aGUgdGltZXN0YW1wIGFu ZCBjb3VudGVyCmZvciB0aGUKICAgICAgICAgKiAgICBsYXN0IHZibGFuayBiZWZvcmUgdGhlIGRp c3BsYXkgcGlwZWxpbmUgd2FzIHNodXQgb2ZmLiBUaGUKc2ltcGxlc3QKICAgICAgICAgKiAgICB3 YXkgdG8gYWNoaWV2ZSB0aGF0IGlzIGNhbGxpbmcKZHJtX2NydGNfc2VuZF92YmxhbmtfZXZlbnQo KQogICAgICAgICAqICAgIHNvbWV3aGVuIGFmdGVyIGRybV9jcnRjX3ZibGFua19vZmYoKSBoYXMg YmVlbiBjYWxsZWQuCgpUaGlzIHN0aWxsIHNlZW1zIGxpa2UgYSBzZW5zaWJsZSBjaGFuZ2UgZm9y IHdoZW4gdGhlIGNydGMgaXMgYmVpbmcKZGlzYWJsZWQuCgoKCj4gPiA+ICAgICAgIHNwaW5fbG9j a19pcnEoJmNydGMtPmRldi0+ZXZlbnRfbG9jayk7Cj4gPiA+IC0gICAgIGlmIChjcnRjLT5zdGF0 ZS0+ZXZlbnQpCj4gPiA+IHsKPiA+ID4gKyAgICAgaWYgKGNydGMtPnN0YXRlLT5ldmVudCAmJiAh Y3J0Yy0+c3RhdGUtPmFjdGl2ZSkgewo+ID4gCj4gPiBUaGlzIGlzIG5vdCBtZW50aW9uZWQgdGhv dWdoLgo+ID4gCj4gPiBJZiB0aGUgcGVuZGluZyBldmVudCBpcyBub3Qgc2VudCBoZXJlLCBJIGFz c3VtZSBpdCB3aWxsIGJlIHBpY2tlZAo+ID4gdXAgYnkKPiA+IC5hdG9taWNfZmx1c2ggYW5kIHdp bGwgdGhlbiBiZSBzZW50IGFmdGVyIHRoZSBmaXJzdCBFT0YgaW50ZXJydXB0Cj4gPiBhZnRlcgo+ ID4gdGhlIG1vZGVzZXQgaXMgY29tcGxldGUuIENhbiB5b3UgZXhwbGFpbiB0aGlzIGluIHRoZSBj b21taXQKPiA+IG1lc3NhZ2U/Cj4gCj4gWWVhaCBsb29rcyBjb3JyZWN0ICh5b3Ugb25seSB3YW50 IHRvIGdlbmVyYXRlIHRoZSBldmVudCBoZXJlIHdoZW4gdGhlCj4gY3J0YyBzdGF5cyBvZmYpLCBp ZiBpdCBnZXRzIHJlLWVuYWJsZWQgdGhlIGV2ZW50IHNob3VsZCBvbmx5IGJlCj4gZ2VuZXJhdGVk IGxhdGVyIG9uIG9uY2UgdGhhdCdzIGFsbCBmaW5pc2hlZC4gQnV0IHNlcGFyYXRlIGJ1Z2ZpeC4K PiAtRGFuaWVsCj4gCgpJdCBsb29rcyBsaWtlIHRoaXMgaXMgYWN0dWFsbHkgdGhlIGZpeCBuZWVk ZWQgdG8gYXZvaWQgdGhlIGJvZ3VzCnRpbWVzdGFtcC4KCkkgY2FuIHNwbGl0IHRoaXMgcGF0Y2gg dXAgaW4gdG8gMiBjb21taXRzIGlmIGRlc2lyZWQ/Cgo+ID4gCj4gPiBXaXRoIHRoYXQsCj4gPiBS ZXZpZXdlZC1ieTogUGhpbGlwcCBaYWJlbCA8cC56YWJlbEBwZW5ndXRyb25peC5kZT4KPiA+IAo+ ID4gPiAgICAgICAgICAgICAgIGRybV9jcnRjX3NlbmRfdmJsYW5rX2V2ZW50KGNydGMsIGNydGMt PnN0YXRlLQo+ID4gPiA+ZXZlbnQpOwo+ID4gPiAgICAgICAgICAgICAgIGNydGMtPnN0YXRlLT5l dmVudCA9IE5VTEw7Cj4gPiA+ICAgICAgIH0KPiA+ID4gICAgICAgc3Bpbl91bmxvY2tfaXJxKCZj cnRjLT5kZXYtPmV2ZW50X2xvY2spOwo+ID4gPiAtCj4gPiA+IC0gICAgIGRybV9jcnRjX3ZibGFu a19vZmYoY3J0Yyk7Cj4gPiA+ICB9Cj4gPiA+IAo+ID4gPiAgc3RhdGljIHZvaWQgaW14X2RybV9j cnRjX3Jlc2V0KHN0cnVjdCBkcm1fY3J0YyAqY3J0YykKPiA+IAo+ID4gcmVnYXJkcwo+ID4gUGhp bGlwcAo+ID4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K PiA+IGRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKPiA+IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKPiA+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v ZHJpLWRldmVsCj4gCj4gCj4gCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVz a3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9k cmktZGV2ZWw=