From: Andy Gross <andy.gross@ti.com>
To: Rob Clark <rob@ti.com>
Cc: Greg Kroah-Hartman <greg@kroah.com>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/omap: Fix release of refill engine
Date: Fri, 12 Oct 2012 09:44:50 -0500 [thread overview]
Message-ID: <50782CE2.3090603@ti.com> (raw)
In-Reply-To: <CAF6AEGt8MYqHN5qEDTiSTpH9Lat0HXJHP_ZmaUUhVxNfAb=yZA@mail.gmail.com>
On 10/12/2012 08:44 AM, Rob Clark wrote:
>
> US);
>
> for (i = 0; i < dmm->num_engines; i++) {
> - if (status & DMM_IRQSTAT_LST)
> + if (status & DMM_IRQSTAT_LST) {
> wake_up_interruptible(&dmm->engines[i].wait_for_refill);
>
> + if (&dmm->engines[i].async)
> Are you sure about that & ? That looks like a typo, rather than what you want..
Good catch. I'll fix that, retest, and resubmit.
next prev parent reply other threads:[~2012-10-12 14:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-12 4:08 [PATCH] drm/omap: Fix release of refill engine Andy Gross
2012-10-12 13:44 ` Rob Clark
2012-10-12 14:44 ` Andy Gross [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-10-12 15:56 Andy Gross
2012-10-12 15:58 ` Andy Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50782CE2.3090603@ti.com \
--to=andy.gross@ti.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=greg@kroah.com \
--cc=rob@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox