Re: Linux 3.7-rc1 (nouveau_bios_score oops).

From: Martin Peres <martin.peres@labri.fr>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "Paweł Sikora" <pawel.sikora@agmk.net>,
	"Daniel Vetter" <daniel.vetter@ffwll.ch>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	"Ben Skeggs" <bskeggs@redhat.com>,
	marcheu@chromium.org
Subject: Re: Linux 3.7-rc1 (nouveau_bios_score oops).
Date: Sat, 20 Oct 2012 00:41:48 +0200	[thread overview]
Message-ID: <5081D72C.2080309@labri.fr> (raw)
In-Reply-To: <CA+55aFy8Te9VFaZRZSDYMehbfg-qLDBYv6=EKncQ2=J2XaF+Vg@mail.gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 662 bytes --]

On 10/19/12 23:25, Linus Torvalds wrote:
> Added more appropriate people to this. Added both i915 and nouveau
> people, since apparently that fine piece of hardware has both.
>
> Guys, any ideas?
>
> Paweł, could you perhaps get a photo of the oops and post it
> somewhere? I'm assuming the oops happens early during boot and you
> never get a usable machine with dmesg - but if you do, then please do
> post the whole dmesg too.
>
>                Linus
Hi Linus,

You must have missed the oops that was attached to the mail: 
http://www.spinics.net/lists/kernel/msg1420355.html

Paweł, could you try the attached patch please ?

Martin


[-- Attachment #1.2: Type: text/html, Size: 1229 bytes --]

[-- Attachment #2: 0001-drm-nouveau-bios-improve-error-handling-when-reading.patch --]
[-- Type: text/x-patch, Size: 1018 bytes --]

>From ea15dc1cf87236da78e8e88ecc3864ffab006ae0 Mon Sep 17 00:00:00 2001
From: Martin Peres <martin.peres@labri.fr>
Date: Sat, 20 Oct 2012 00:08:15 +0200
Subject: [PATCH] drm/nouveau/bios: improve error handling when reading the
 vbios from ACPI

Reported-by: Pawel Sikora <pawel.sikora@agmk.net>
Signed-off-by: Martin Peres <martin.peres@labri.fr>
---
 drivers/gpu/drm/nouveau/core/subdev/bios/base.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/nouveau/core/subdev/bios/base.c b/drivers/gpu/drm/nouveau/core/subdev/bios/base.c
index 2fbb6df..e31d8fc 100644
--- a/drivers/gpu/drm/nouveau/core/subdev/bios/base.c
+++ b/drivers/gpu/drm/nouveau/core/subdev/bios/base.c
@@ -188,8 +188,10 @@ nouveau_bios_shadow_acpi(struct nouveau_bios *bios)
 	int cnt = 65536 / 4096;
 	int ret;
 
-	if (!nouveau_acpi_rom_supported(pdev))
+	if (!nouveau_acpi_rom_supported(pdev)) {
+		bios->data = NULL;
 		return;
+	}
 
 	bios->data = kmalloc(65536, GFP_KERNEL);
 	bios->size = 0;
-- 
1.7.12.3


[-- Attachment #3: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
