* [PATCH libdrm] libkms: fix the name of the intel driver in linux_sysfs_create
@ 2012-09-05 11:30 Ander Conselvan de Oliveira
2012-10-29 13:47 ` Ander Conselvan de Oliveira
0 siblings, 1 reply; 2+ messages in thread
From: Ander Conselvan de Oliveira @ 2012-09-05 11:30 UTC (permalink / raw)
To: dri-devel; +Cc: Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
linux_sysfs_create() checked for a driver named "intel" while the intel
driver is called "i915". This went unnoticed because in kernels 2.6.39
and after this code path was never reached because of the dumb buffer
interface. On earlier kernels, kms_create() would fail.
Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
---
libkms/linux.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/libkms/linux.c b/libkms/linux.c
index fc4f205..dde74f7 100644
--- a/libkms/linux.c
+++ b/libkms/linux.c
@@ -101,7 +101,7 @@ linux_from_sysfs(int fd, struct kms_driver **out)
if (ret)
return ret;
- if (!strcmp(name, "intel"))
+ if (!strcmp(name, "i915"))
ret = intel_create(fd, out);
#ifdef HAVE_VMWGFX
else if (!strcmp(name, "vmwgfx"))
--
1.7.4.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH libdrm] libkms: fix the name of the intel driver in linux_sysfs_create
2012-09-05 11:30 [PATCH libdrm] libkms: fix the name of the intel driver in linux_sysfs_create Ander Conselvan de Oliveira
@ 2012-10-29 13:47 ` Ander Conselvan de Oliveira
0 siblings, 0 replies; 2+ messages in thread
From: Ander Conselvan de Oliveira @ 2012-10-29 13:47 UTC (permalink / raw)
To: dri-devel; +Cc: Ander Conselvan de Oliveira, intel-gfx
Ping?
On 09/05/2012 02:30 PM, Ander Conselvan de Oliveira wrote:
> From: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
>
> linux_sysfs_create() checked for a driver named "intel" while the intel
> driver is called "i915". This went unnoticed because in kernels 2.6.39
> and after this code path was never reached because of the dumb buffer
> interface. On earlier kernels, kms_create() would fail.
>
> Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
> ---
> libkms/linux.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/libkms/linux.c b/libkms/linux.c
> index fc4f205..dde74f7 100644
> --- a/libkms/linux.c
> +++ b/libkms/linux.c
> @@ -101,7 +101,7 @@ linux_from_sysfs(int fd, struct kms_driver **out)
> if (ret)
> return ret;
>
> - if (!strcmp(name, "intel"))
> + if (!strcmp(name, "i915"))
> ret = intel_create(fd, out);
> #ifdef HAVE_VMWGFX
> else if (!strcmp(name, "vmwgfx"))
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-10-29 13:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-05 11:30 [PATCH libdrm] libkms: fix the name of the intel driver in linux_sysfs_create Ander Conselvan de Oliveira
2012-10-29 13:47 ` Ander Conselvan de Oliveira
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).