From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ander Conselvan de Oliveira <conselvan2@gmail.com>
Subject: Re: [PATCH libdrm] libkms: fix the name of the intel driver in
	linux_sysfs_create
Date: Mon, 29 Oct 2012 15:47:31 +0200
Message-ID: <508E88F3.4050409@gmail.com>
References: <1346844635-21447-1-git-send-email-conselvan2@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org>
In-Reply-To: <1346844635-21447-1-git-send-email-conselvan2@gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
To: dri-devel@lists.freedesktop.org
Cc: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>, intel-gfx@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

Ping?

On 09/05/2012 02:30 PM, Ander Conselvan de Oliveira wrote:
> From: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
>
> linux_sysfs_create() checked for a driver named "intel" while the intel
> driver is called "i915". This went unnoticed because in kernels 2.6.39
> and after this code path was never reached because of the dumb buffer
> interface. On earlier kernels, kms_create() would fail.
>
> Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
> ---
>   libkms/linux.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/libkms/linux.c b/libkms/linux.c
> index fc4f205..dde74f7 100644
> --- a/libkms/linux.c
> +++ b/libkms/linux.c
> @@ -101,7 +101,7 @@ linux_from_sysfs(int fd, struct kms_driver **out)
>   	if (ret)
>   		return ret;
>
> -	if (!strcmp(name, "intel"))
> +	if (!strcmp(name, "i915"))
>   		ret = intel_create(fd, out);
>   #ifdef HAVE_VMWGFX
>   	else if (!strcmp(name, "vmwgfx"))
>