Re: [PATCH 3/4] drm/ttm: remove ttm_bo_device->nice_mode

[Thomas Hellstrom <thellstrom@vmware.com>]

On 11/06/2012 10:49 PM, Marcin Slusarz wrote:
> It's unused.
>
> Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com>
> Cc: Thomas Hellstrom <thellstrom@vmware.com>
> ---
>   drivers/gpu/drm/ttm/ttm_bo.c    | 1 -
>   include/drm/ttm/ttm_bo_driver.h | 3 ---
>   2 files changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c
> index 412486c..da7a985 100644
> --- a/drivers/gpu/drm/ttm/ttm_bo.c
> +++ b/drivers/gpu/drm/ttm/ttm_bo.c
> @@ -1570,7 +1570,6 @@ int ttm_bo_device_init(struct ttm_bo_device *bdev,
>   		goto out_no_addr_mm;
>   
>   	INIT_DELAYED_WORK(&bdev->wq, ttm_bo_delayed_workqueue);
> -	bdev->nice_mode = true;
>   	INIT_LIST_HEAD(&bdev->ddestroy);
>   	bdev->dev_mapping = NULL;
>   	bdev->glob = glob;
> diff --git a/include/drm/ttm/ttm_bo_driver.h b/include/drm/ttm/ttm_bo_driver.h
> index d803b92..95628e7 100644
> --- a/include/drm/ttm/ttm_bo_driver.h
> +++ b/include/drm/ttm/ttm_bo_driver.h
> @@ -521,8 +521,6 @@ struct ttm_bo_global {
>    * lru_lock: Spinlock that protects the buffer+device lru lists and
>    * ddestroy lists.
>    * @val_seq: Current validation sequence.
> - * @nice_mode: Try nicely to wait for buffer idle when cleaning a manager.
> - * If a GPU lockup has been detected, this is forced to 0.
>    * @dev_mapping: A pointer to the struct address_space representing the
>    * device address space.
>    * @wq: Work queue structure for the delayed delete workqueue.
> @@ -556,7 +554,6 @@ struct ttm_bo_device {
>   	 * Protected by load / firstopen / lastclose /unload sync.
>   	 */
>   
> -	bool nice_mode;
>   	struct address_space *dev_mapping;
>   
>   	/*

Reviewed-by: Thomas Hellstrom <thellstrom@vmware.com>