From: Thomas Hellstrom <thellstrom@vmware.com>
To: Maarten Lankhorst <maarten.lankhorst@canonical.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH, FIXED] drm/vmwgfx: always use ttm_bo_is_reserved
Date: Fri, 30 Nov 2012 09:53:20 +0100 [thread overview]
Message-ID: <50B87400.3060209@vmware.com> (raw)
In-Reply-To: <50B86BED.2050205@canonical.com>
Reviewed-by: Thomas Hellstrom <thellstrom@vmware.com>
On 11/30/2012 09:18 AM, Maarten Lankhorst wrote:
> This was missed during the initial conversion, most likely due to the refactoring here.
>
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@canonical.com>
> ---
> Woops, forgot to stg refresh before sending, fixed. :-)
>
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_resource.c b/drivers/gpu/drm/vmwgfx/vmwgfx_resource.c
> index 93dffe3..ddc8db8 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_resource.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_resource.c
> @@ -939,13 +939,13 @@ void vmw_resource_unreserve(struct vmw_resource *res,
> if (new_backup && new_backup != res->backup) {
>
> if (res->backup) {
> - BUG_ON(atomic_read(&res->backup->base.reserved) == 0);
> + BUG_ON(!ttm_bo_is_reserved(&res->backup->base));
> list_del_init(&res->mob_head);
> vmw_dmabuf_unreference(&res->backup);
> }
>
> res->backup = vmw_dmabuf_reference(new_backup);
> - BUG_ON(atomic_read(&new_backup->base.reserved) == 0);
> + BUG_ON(!ttm_bo_is_reserved(&new_backup->base));
> list_add_tail(&res->mob_head, &new_backup->res_list);
> }
> if (new_backup)
prev parent reply other threads:[~2012-11-30 8:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-30 8:18 [PATCH, FIXED] drm/vmwgfx: always use ttm_bo_is_reserved Maarten Lankhorst
2012-11-30 8:53 ` Thomas Hellstrom [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50B87400.3060209@vmware.com \
--to=thellstrom@vmware.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=maarten.lankhorst@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox