From: Maarten Lankhorst <maarten.lankhorst@canonical.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH v3 1/3] drm: add prime helpers
Date: Tue, 29 Jan 2013 17:59:01 +0100 [thread overview]
Message-ID: <5107FFD5.7020409@canonical.com> (raw)
In-Reply-To: <CAKMK7uF-AdgoW_aHmVYu_nCkq=9hx0uUt_RAsUdaH7JkCsdmsQ@mail.gmail.com>
Op 17-01-13 09:40, Daniel Vetter schreef:
> On Thu, Jan 17, 2013 at 12:36 AM, Aaron Plattner <aplattner@nvidia.com> wrote:
>> Can I consider this a Reviewed-by?
> Essentially it was just a drive-by bikeshed ;-) I think it'd be good
> if Maarten takes a look at this and checks whether it complies with
> his massive prime/dma_buf rework to use fences and ticketing
> reservations ...
> -Daniel
Looks ok to me, I just wish there was a unpin being called on dma-buf release or if dma_buf_export fails, instead of only implicitly during destruction.
But that's something you couldn't have known, since it seems darktama still didn't accept my patch for that. :(
~Maarten
next prev parent reply other threads:[~2013-01-29 16:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-15 20:47 [PATCH v3 0/3] Prime helpers Aaron Plattner
2013-01-15 20:47 ` [PATCH v3 1/3] drm: add prime helpers Aaron Plattner
2013-01-16 9:50 ` Daniel Vetter
2013-01-16 23:36 ` Aaron Plattner
2013-01-17 8:40 ` Daniel Vetter
2013-01-29 16:59 ` Maarten Lankhorst [this message]
2013-04-12 14:58 ` Daniel Vetter
2013-04-12 15:13 ` Aaron Plattner
2013-04-12 18:53 ` Daniel Vetter
2013-06-18 23:08 ` Laurent Pinchart
2013-06-18 23:28 ` Aaron Plattner
2013-06-18 23:37 ` Laurent Pinchart
2013-06-19 0:24 ` Aaron Plattner
2013-01-15 20:47 ` [PATCH 2/3] drm/nouveau: use " Aaron Plattner
2013-01-15 20:47 ` [PATCH 3/3] drm/radeon: " Aaron Plattner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5107FFD5.7020409@canonical.com \
--to=maarten.lankhorst@canonical.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox