From: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
To: "Rafael J. Wysocki" <rjw@sisk.pl>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Yinghai Lu <yinghai@kernel.org>, Toshi Kani <toshi.kani@hp.com>,
daniel.vetter@ffwll.ch, airlied@linux.ie,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 0/4] Fix acpi_bus_get_device() check
Date: Thu, 31 Jan 2013 12:19:11 +0900 [thread overview]
Message-ID: <5109E2AF.2000107@jp.fujitsu.com> (raw)
In-Reply-To: <5109E11A.5030400@jp.fujitsu.com>
acpi_bus_get_device() returns int not acpi_status.
The patch change not to apply ACPI_FAILURE() to the return value of
acpi_bus_get_device().
Signed-off-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
---
drivers/gpu/drm/i915/intel_opregion.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-pm/drivers/gpu/drm/i915/intel_opregion.c
===================================================================
--- linux-pm.orig/drivers/gpu/drm/i915/intel_opregion.c 2013-01-31 11:39:37.075849905 +0900
+++ linux-pm/drivers/gpu/drm/i915/intel_opregion.c 2013-01-31 11:52:18.796850274 +0900
@@ -347,7 +347,7 @@ static void intel_didl_outputs(struct dr
int i = 0;
handle = DEVICE_ACPI_HANDLE(&dev->pdev->dev);
- if (!handle || ACPI_FAILURE(acpi_bus_get_device(handle, &acpi_dev)))
+ if (!handle || acpi_bus_get_device(handle, &acpi_dev))
return;
if (acpi_is_video_device(acpi_dev))
next parent reply other threads:[~2013-01-31 3:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1451967.YMyGeCCNtu@vostro.rjw.lan>
[not found] ` <6099377.PFvsxPeyib@vostro.rjw.lan>
[not found] ` <5109E11A.5030400@jp.fujitsu.com>
2013-01-31 3:19 ` Yasuaki Ishimatsu [this message]
2013-01-31 3:27 ` [RESEND PATCH 4/4] GPU/i915: Fix acpi_bus_get_device() check in drivers/gpu/drm/i915/intel_opregion.c Yasuaki Ishimatsu
2013-01-31 10:03 ` Daniel Vetter
2013-02-01 0:50 ` [UPDATE][PATCH " Yasuaki Ishimatsu
2013-02-01 0:53 ` Yasuaki Ishimatsu
2013-02-01 1:14 ` Yasuaki Ishimatsu
2013-02-01 10:03 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5109E2AF.2000107@jp.fujitsu.com \
--to=isimatu.yasuaki@jp.fujitsu.com \
--cc=airlied@linux.ie \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rjw@sisk.pl \
--cc=toshi.kani@hp.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox