From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
dri-devel@lists.freedesktop.org,
linux-renesas-soc@vger.kernel.org,
Kieran Bingham <kieran.bingham@ideasonboard.com>
Subject: Re: [PATCH] drm: rcar-du: Fix comments to comply with the kernel coding style
Date: Fri, 14 Jul 2017 02:08:06 +0300 [thread overview]
Message-ID: <5122189.VoqZUFnf2n@avalon> (raw)
In-Reply-To: <20170713123815.5bdayu2kkzp7tnl5@phenom.ffwll.local>
Hi Daniel,
On Thursday 13 Jul 2017 14:38:15 Daniel Vetter wrote:
> On Wed, Jul 12, 2017 at 08:00:42PM +0300, Laurent Pinchart wrote:
> > To avoid mixing comment styles when new comments complying with the
> > kernel coding style are introduced, fix all multiline comments in one
> > go.
> >
> > Signed-off-by: Laurent Pinchart
> > <laurent.pinchart+renesas@ideasonboard.com>
>
> Afaik the entirety of davem's -net is commented like this, this is
> checkpatch being a bit over the top. And drm is often commented like this
> too.
I have a slight preference for the "-net" style, but given that both
checkpatch and Linus complain about it, and that I receive patches with the
"correct" coding style, I'd rather not mix the two in the driver.
--
Regards,
Laurent Pinchart
prev parent reply other threads:[~2017-07-13 23:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-12 17:00 [PATCH] drm: rcar-du: Fix comments to comply with the kernel coding style Laurent Pinchart
2017-07-13 11:19 ` Kieran Bingham
2017-07-13 12:38 ` Daniel Vetter
2017-07-13 23:08 ` Laurent Pinchart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5122189.VoqZUFnf2n@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kieran.bingham@ideasonboard.com \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-renesas-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox