From: Jani Nikula <jani.nikula@linux.intel.com>
To: Thomas Zimmermann <tzimmermann@suse.de>,
javierm@redhat.com, ardb@kernel.org, ilias.apalodimas@linaro.org,
maarten.lankhorst@linux.intel.com, mripard@kernel.org,
simona@ffwll.ch, airlied@gmail.com
Cc: dri-devel@lists.freedesktop.org, linux-efi@vger.kernel.org,
sashiko-reviews@lists.linux.dev
Subject: Re: [PATCH v2 2/3] drm/edid: Add drm_edid_get_preferred_size()
Date: Mon, 31 Aug 2026 16:36:07 +0300 [thread overview]
Message-ID: <5126b708b6e77b6bb15a355f858fcd54b732f653@intel.com> (raw)
In-Reply-To: <4645113d-3b31-4d92-b392-5d5284225211@suse.de>
On Mon, 31 Aug 2026, Thomas Zimmermann <tzimmermann@suse.de> wrote:
> Absolutely. The only reason I added this helper is that the driver
> needs the size for setting up the display pipeline before the connector
> exists. I looked into using the existing code without the connector, but
> that refactoring seemed to do more harm than good. Hence the new helper.
Heh, I looked into that too while reviewing, and agreed.
> Should the new function be named drm_edid_detect_panel_size() to signal
> the use case?
Surprisingly, no strong feelings either way, both work for me.
BR,
Jani.
--
Jani Nikula, Intel
next prev parent reply other threads:[~2026-08-31 13:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-31 9:27 [PATCH v2 0/3] sysfb: Fix display output on Lenovo D330 (and others) Thomas Zimmermann
2026-08-31 9:27 ` [PATCH v2 1/3] firmware/sysfb: Remove rotation quirk for Lenovo D330 Thomas Zimmermann
2026-08-31 9:47 ` sashiko-bot
2026-08-31 12:49 ` Jani Nikula
2026-08-31 13:23 ` Thomas Zimmermann
2026-08-31 13:32 ` Jani Nikula
2026-08-31 9:27 ` [PATCH v2 2/3] drm/edid: Add drm_edid_get_preferred_size() Thomas Zimmermann
2026-08-31 13:13 ` Jani Nikula
2026-08-31 13:31 ` Thomas Zimmermann
2026-08-31 13:36 ` Jani Nikula [this message]
2026-08-31 16:56 ` Jani Nikula
2026-08-31 9:27 ` [PATCH v2 3/3] drm/sysfb: Use preferred panel size for panel orientation quirks Thomas Zimmermann
2026-08-31 13:23 ` Jani Nikula
2026-08-31 13:43 ` Thomas Zimmermann
2026-08-31 14:11 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5126b708b6e77b6bb15a355f858fcd54b732f653@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=airlied@gmail.com \
--cc=ardb@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=ilias.apalodimas@linaro.org \
--cc=javierm@redhat.com \
--cc=linux-efi@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox