From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
Steffen Trumtrar <s.trumtrar@pengutronix.de>
Subject: Re: [PATCH 5/5] videomode: rename fields
Date: Tue, 12 Mar 2013 15:40:14 +0200 [thread overview]
Message-ID: <513F303E.5000007@ti.com> (raw)
In-Reply-To: <16625567.P7GdYge43z@avalon>
[-- Attachment #1.1: Type: text/plain, Size: 1479 bytes --]
Hi,
On 2013-03-12 15:37, Laurent Pinchart wrote:
> Hi Tomi,
>
> Thanks for the patch.
>
> On Tuesday 12 March 2013 12:19:38 Tomi Valkeinen wrote:
>> Structs videomode and display_timing have rather long field names for
>> the timing values. Nothing wrong with that as such, but this patch
>> changes them to abbreviations for the following reasons:
>>
>> * The timing values often need to be used in calculations, and long
>> field names makes their direct use clumsier.
>>
>> * The current names are a bit of a mishmash: some words are used as
>> such, some are shortened, and for some only first letter is used. Some
>> names use underscode, some don't. All this makes it difficult to
>> remember what the field names are.
>>
>> * The abbreviations used in this patch are very common, and there
>> shouldn't be any misunderstanding about their meaning.
>>
>> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
>> Cc: Steffen Trumtrar <s.trumtrar@pengutronix.de>
>> ---
>
> I have no strong opinion on this, but I find the existing names easier to
> read. I might be biased by having read them often though.
Yes, the last patch was a bit of a "teaser" =). I found myself typoing
them a lot, using helper local variables to shorten the code lines, and
as I mention in the description, I find them a bit of a mishmash. So,
while they're not used in any drivers yet, I thought it'd be worth a
shot to change them.
Tomi
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 899 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2013-03-12 13:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-12 10:19 [PATCH 1/5] videomode: simplify videomode Kconfig and Makefile Tomi Valkeinen
2013-03-12 10:19 ` [PATCH 2/5] videomode: combine videomode dmt_flags and data_flags Tomi Valkeinen
2013-03-12 10:19 ` [PATCH 3/5] videomode: create enum for videomode's display flags Tomi Valkeinen
2013-03-12 10:19 ` [PATCH 4/5] videomode: remove timing_entry_index Tomi Valkeinen
2013-03-12 10:19 ` [PATCH 5/5] videomode: rename fields Tomi Valkeinen
2013-03-12 13:37 ` Laurent Pinchart
2013-03-12 13:40 ` Tomi Valkeinen [this message]
2013-03-18 8:00 ` Daniel Vetter
2013-03-18 12:28 ` Tomi Valkeinen
2013-03-12 13:53 ` Steffen Trumtrar
2013-03-12 13:34 ` [PATCH 1/5] videomode: simplify videomode Kconfig and Makefile Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=513F303E.5000007@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=s.trumtrar@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox