dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Archit Taneja <archit@ti.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v4 09/21] modetest: Allow specifying plane position
Date: Tue, 26 Mar 2013 14:14:14 +0530	[thread overview]
Message-ID: <51515FDE.6080901@ti.com> (raw)
In-Reply-To: <2279969.E0Cttns2Pm@avalon>

On Tuesday 26 March 2013 04:11 AM, Laurent Pinchart wrote:
> Hi Archit,
>
> On Monday 25 March 2013 11:44:35 Archit Taneja wrote:
>> Hi Laurent,
>>
>> On Tuesday 19 March 2013 08:25 PM, Laurent Pinchart wrote:
>>> Extend the -P option to allow specifying the plane x and y offsets. The
>>> position is optional, if not specified the plane will be positioned at
>>> the center of the screen as before.
>>
>> Thanks for this series. I tested the patches with a Panda ES board.
>>
>> I was facing issues with the plane position though, when I execute this
>> on the command line:
>>
>> ./modetest -s 12:1440x900 -P 6:(0,0)/300x200
>>
>> I get a syntax error by bash saying it doesn't expect "(". I guess there
>> are ways around to get over this,
>
> I use
>
> ./modetest -s 12:1440x900 -P '6:(0,0)/300x200'
>
>> but I was wondering if we could get rid of the braces all together to keep
>> it simple? The "/" character could be used to figure out whether the user
>> has also mentioned position or not.
>
> It makes parsing the option a bit more complex, but I can do that if you think
> it's better.

I think it's fine. After googling a bit on the syntax error issue, I 
thought that putting the command in a script file was the only option, 
but your method above is convenient enough.

Thanks,
Archit

  reply	other threads:[~2013-03-26  8:45 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-19 14:55 [PATCH v4 00/21] modetest enhancements Laurent Pinchart
2013-03-19 14:55 ` [PATCH v4 01/21] modetest: Fix warnings Laurent Pinchart
2013-03-19 14:55 ` [PATCH v4 02/21] modetest: Remove extern declarations of opt(arg|ind|err|opt) Laurent Pinchart
2013-03-19 14:55 ` [PATCH v4 03/21] modetest: Sort command line arguments Laurent Pinchart
2013-03-19 14:55 ` [PATCH v4 04/21] modetest: Add a command line parameter to select the driver Laurent Pinchart
2013-04-03 10:06   ` Ville Syrjälä
2013-04-04 13:22     ` Laurent Pinchart
2013-03-19 14:55 ` [PATCH v4 05/21] modetest: Add a command line parameter to drop master after mode set Laurent Pinchart
2013-03-19 14:55 ` [PATCH v4 06/21] modetest: Retrieve all resources in one go Laurent Pinchart
2013-03-19 14:55 ` [PATCH v4 07/21] modetest: Don't limit mode set and planes to two instances Laurent Pinchart
2013-03-19 14:55 ` [PATCH v4 08/21] modetest: Add a command line parameter to set properties Laurent Pinchart
2013-03-28 12:23   ` Laurent Pinchart
2013-03-19 14:55 ` [PATCH v4 09/21] modetest: Allow specifying plane position Laurent Pinchart
2013-03-25  6:14   ` Archit Taneja
2013-03-25 22:41     ` Laurent Pinchart
2013-03-26  8:44       ` Archit Taneja [this message]
2013-03-27 15:57   ` Ville Syrjälä
2013-03-27 17:15     ` Ville Syrjälä
2013-03-28  0:16       ` Laurent Pinchart
2013-03-28 10:44         ` Ville Syrjälä
2013-04-04 16:24       ` Laurent Pinchart
2013-04-05 15:15         ` Ville Syrjälä
2013-03-28  0:17     ` Laurent Pinchart
2013-03-19 14:55 ` [PATCH v4 10/21] modetest: Print the plane ID when setting up a plane Laurent Pinchart
2013-03-19 14:55 ` [PATCH v4 11/21] modetest: Remove the -m argument Laurent Pinchart
2013-03-19 14:55 ` [PATCH v4 12/21] modetest: Create a device structure Laurent Pinchart
2013-03-19 14:55 ` [PATCH v4 13/21] modetest: Compute CRTC pipe number as needed Laurent Pinchart
2013-03-19 14:55 ` [PATCH v4 14/21] modetest: Remove the struct connector_arg encoder field Laurent Pinchart
2013-03-19 14:55 ` [PATCH v4 15/21] modetest: Store the crtc in the connector_arg structure Laurent Pinchart
2013-03-19 14:55 ` [PATCH v4 16/21] modetest: Store the mode in the crtc structure Laurent Pinchart
2013-03-19 14:55 ` [PATCH v4 17/21] modetest: Give the CRTC ID to the -P option Laurent Pinchart
2013-03-19 18:21   ` Rob Clark
2013-03-20 15:01     ` Laurent Pinchart
2013-03-19 14:55 ` [PATCH v4 18/21] modetest: Split mode setting and plane setup Laurent Pinchart
2013-03-19 14:56 ` [PATCH v4 19/21] modetest: Rename struct connector_arg to struct pipe_arg Laurent Pinchart
2013-03-19 14:56 ` [PATCH v4 20/21] modetest: Support pipes with multiple connectors Laurent Pinchart
2013-03-19 14:56 ` [PATCH v4 21/21] modetest: Try all possible encoders for a connector Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51515FDE.6080901@ti.com \
    --to=archit@ti.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=laurent.pinchart@ideasonboard.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox