public inbox for dri-devel@lists.freedesktop.org
 help / color / mirror / Atom feed
* An other radeon ring count patch
@ 2014-04-23  6:49 Mathias Fröhlich
  2014-04-28 14:18 ` Alex Deucher
  0 siblings, 1 reply; 2+ messages in thread
From: Mathias Fröhlich @ 2014-04-23  6:49 UTC (permalink / raw)
  To: Christian Koenig, alexander.deucher,
	dri-devel@lists.freedesktop.org

[-- Attachment #1: Type: text/plain, Size: 263 bytes --]


Hi Christian, Alex,

While looking over the rest of the ring counts
I noticed an other one, this time we reserve too
much which cannot even be a potential problem.
Anyway, it's nicer to be correct.

Attached that patch to uvd_v1_0_ring_test()

Greetings

Mathias

[-- Attachment #2: 0001-drm-radeon-fix-count-in-uvd_v1_0_ring_test.patch --]
[-- Type: text/x-patch, Size: 1066 bytes --]

>From 889f02196e1a3a571aac8e878574e48a7469cb42 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Mathias=20Fr=C3=B6hlich?= <Mathias.Froehlich@gmx.net>
Date: Wed, 23 Apr 2014 08:37:12 +0200
Subject: [PATCH] drm/radeon: fix count in uvd_v1_0_ring_test()
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Should be 2 rather than 3.

Signed-off-by: Mathias Fröhlich <Mathias.Froehlich@gmx.net>
---
 drivers/gpu/drm/radeon/uvd_v1_0.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/radeon/uvd_v1_0.c b/drivers/gpu/drm/radeon/uvd_v1_0.c
index 0a243f0..d50f510 100644
--- a/drivers/gpu/drm/radeon/uvd_v1_0.c
+++ b/drivers/gpu/drm/radeon/uvd_v1_0.c
@@ -320,7 +320,7 @@ int uvd_v1_0_ring_test(struct radeon_device *rdev, struct radeon_ring *ring)
 	int r;
 
 	WREG32(UVD_CONTEXT_ID, 0xCAFEDEAD);
-	r = radeon_ring_lock(rdev, ring, 3);
+	r = radeon_ring_lock(rdev, ring, 2);
 	if (r) {
 		DRM_ERROR("radeon: cp failed to lock ring %d (%d).\n",
 			  ring->idx, r);
-- 
1.9.0


[-- Attachment #3: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: An other radeon ring count patch
  2014-04-23  6:49 An other radeon ring count patch Mathias Fröhlich
@ 2014-04-28 14:18 ` Alex Deucher
  0 siblings, 0 replies; 2+ messages in thread
From: Alex Deucher @ 2014-04-28 14:18 UTC (permalink / raw)
  To: Mathias Fröhlich
  Cc: Deucher, Alexander, Christian Koenig,
	dri-devel@lists.freedesktop.org

On Wed, Apr 23, 2014 at 2:49 AM, Mathias Fröhlich
<Mathias.Froehlich@gmx.net> wrote:
>
> Hi Christian, Alex,
>
> While looking over the rest of the ring counts
> I noticed an other one, this time we reserve too
> much which cannot even be a potential problem.
> Anyway, it's nicer to be correct.
>
> Attached that patch to uvd_v1_0_ring_test()

Reviewed-by: Alex Deucher <alexander.deucher@amd.com>

>
> Greetings
>
> Mathias
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-04-28 14:18 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-23  6:49 An other radeon ring count patch Mathias Fröhlich
2014-04-28 14:18 ` Alex Deucher

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox