From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Inki Dae <inki.dae@samsung.com>
Cc: Tomasz Figa <tomasz.figa@gmail.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
linux-samsung-soc@vger.kernel.org,
Seung-Woo Kim <sw0312.kim@samsung.com>,
DRI mailing list <dri-devel@lists.freedesktop.org>,
devicetree-discuss <devicetree-discuss@lists.ozlabs.org>
Subject: Re: [PATCH] drm/exynos: fix multiple definition build error
Date: Fri, 26 Apr 2013 11:48:50 +0200 [thread overview]
Message-ID: <517A4D82.8010306@samsung.com> (raw)
In-Reply-To: <CAAQKjZPQ4LWTka0rfgPypsh+a-B5gzBv5hEbRYdkrry_C5J6Hg@mail.gmail.com>
On 04/26/2013 10:20 AM, Inki Dae wrote:
> Exactly right. it's my mistake. But now it seems that __mode_of_device_table is
> multi defined at fimd and g2d side so there still is module build error. :(
Since all drivers seem to be linked into single a single module, you
likely need to create a separate table of struct of_device_id just for
the purpose of MODULE_DEVICE_TABLE(of, ...). This table would contain
'compatible' strings for all devices. Or choose of_device_id for just
one device and define MODULE_DEVICE_TABLE() for it in some common place,
e.g. exynos_drm_drv.c. I believe all devices should be listed though.
Thanks,
Sylwester
next prev parent reply other threads:[~2013-04-26 9:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-26 5:03 [PATCH] drm/exynos: fix multiple definition build error Inki Dae
2013-04-26 8:00 ` Tomasz Figa
2013-04-26 8:20 ` Inki Dae
2013-04-26 9:48 ` Sylwester Nawrocki [this message]
2013-04-26 19:42 ` Tomasz Figa
2013-04-26 20:00 ` Sylwester Nawrocki
[not found] ` <517ADCDB.3040101-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-04-28 13:24 ` Inki Dae
2013-04-28 12:52 ` Inki Dae
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=517A4D82.8010306@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=inki.dae@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=sw0312.kim@samsung.com \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox