From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52150C433E1 for ; Thu, 20 Aug 2020 23:01:48 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 11CA82075E for ; Thu, 20 Aug 2020 23:01:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 11CA82075E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 72BC36E040; Thu, 20 Aug 2020 23:01:47 +0000 (UTC) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by gabe.freedesktop.org (Postfix) with ESMTP id 0B87F6E040 for ; Thu, 20 Aug 2020 23:01:45 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C6C6331B; Thu, 20 Aug 2020 16:01:44 -0700 (PDT) Received: from [10.57.40.122] (unknown [10.57.40.122]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 98AAB3F71F; Thu, 20 Aug 2020 16:01:39 -0700 (PDT) Subject: Re: [PATCH 17/18] media/omap3isp: Clean up IOMMU workaround To: Sakari Ailus References: <11d8419744e4e744a9448180801b0c4683328afd.1597931876.git.robin.murphy@arm.com> <20200820165339.GK7145@valkosipuli.retiisi.org.uk> <20200820195536.GL7145@valkosipuli.retiisi.org.uk> From: Robin Murphy Message-ID: <5190a40e-ad24-d98e-3588-b95592ea2db3@arm.com> Date: Fri, 21 Aug 2020 00:01:38 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200820195536.GL7145@valkosipuli.retiisi.org.uk> Content-Language: en-GB X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: geert+renesas@glider.be, dri-devel@lists.freedesktop.org, bjorn.andersson@linaro.org, linux-tegra@vger.kernel.org, thierry.reding@gmail.com, laurent.pinchart@ideasonboard.com, digetx@gmail.com, s-anna@ti.com, will@kernel.org, hch@lst.de, m.szyprowski@samsung.com, linux-samsung-soc@vger.kernel.org, joro@8bytes.org, magnus.damm@gmail.com, linux@armlinux.org.uk, jonathanh@nvidia.com, agross@kernel.org, yong.wu@mediatek.com, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, vdumpa@nvidia.com, linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com, linux-arm-kernel@lists.infradead.org, sw0312.kim@samsung.com, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, t-kristo@ti.com, kyungmin.park@samsung.com Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 2020-08-20 20:55, Sakari Ailus wrote: > On Thu, Aug 20, 2020 at 06:25:19PM +0100, Robin Murphy wrote: >> On 2020-08-20 17:53, Sakari Ailus wrote: >>> Hi Robin, >>> >>> On Thu, Aug 20, 2020 at 04:08:36PM +0100, Robin Murphy wrote: >>>> Now that arch/arm is wired up for default domains and iommu-dma, devices >>>> behind IOMMUs will get mappings set up automatically as appropriate, so >>>> there is no need for drivers to do so manually. >>>> >>>> Signed-off-by: Robin Murphy >>> >>> Thanks for the patch. >> >> Many thanks for testing so quickly! >> >>> I haven't looked at the details but it seems that this causes the buffer >>> memory allocation to be physically contiguous, which causes a failure to >>> allocate video buffers of entirely normal size. I guess that was not >>> intentional? >> >> Hmm, it looks like the device ends up with the wrong DMA ops, which implies >> something didn't go as expected with the earlier IOMMU setup and default >> domain creation. Chances are that either I missed some subtlety in the >> omap_iommu change, or I've fundamentally misjudged how the ISP probing works >> and it never actually goes down the of_iommu_configure() path in the first >> place. Do you get any messages from the IOMMU layer earlier on during boot? > > I do get these: > > [ 2.934936] iommu: Default domain type: Translated > [ 2.940917] omap-iommu 480bd400.mmu: 480bd400.mmu registered > [ 2.946899] platform 480bc000.isp: Adding to iommu group 0 > So that much looks OK, if there are no obvious errors. Unfortunately there's no easy way to tell exactly what of_iommu_configure() is doing (beyond enabling a couple of vague debug messages). The first thing I'll do tomorrow is double-check whether it's really working on my boards here, or whether I was just getting lucky with CMA... (I assume you don't have CMA enabled if you're ending up in remap_allocator_alloc()) Robin. _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel