From: "Christian König" <deathsimple@vodafone.de>
To: alexdeucher@gmail.com
Cc: Alex Deucher <alexander.deucher@amd.com>,
Matthew Garrett <mjg59@srcf.ucam.org>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/radeon: revert Apple re-POST hack
Date: Thu, 23 May 2013 10:13:23 +0200 [thread overview]
Message-ID: <519DCFA3.6060706@vodafone.de> (raw)
In-Reply-To: <1369244301-25974-1-git-send-email-alexdeucher@gmail.com>
Am 22.05.2013 19:38, schrieb alexdeucher@gmail.com:
> From: Alex Deucher <alexander.deucher@amd.com>
>
> This reverts:
> drm/radeon: re-POST the asic on Apple hardware when booted via EFI
>
> That patch prevents UVD from working on macs when booted in EFI
> mode. The original patch may not be required any more due to other
> fixes for UEFI on non-Mac platforms, but I don't have any Macs.
>
> Fixes:
> https://bugs.freedesktop.org/show_bug.cgi?id=63935
>
> Cc: Matthew Garrett <mjg59@srcf.ucam.org>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/radeon/radeon_device.c | 4 ----
> 1 files changed, 0 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_device.c b/drivers/gpu/drm/radeon/radeon_device.c
> index af82c9b..261fe11 100644
> --- a/drivers/gpu/drm/radeon/radeon_device.c
> +++ b/drivers/gpu/drm/radeon/radeon_device.c
> @@ -467,10 +467,6 @@ bool radeon_card_posted(struct radeon_device *rdev)
> {
> uint32_t reg;
>
> - if (efi_enabled(EFI_BOOT) &&
> - rdev->pdev->subsystem_vendor == PCI_VENDOR_ID_APPLE)
> - return false;
> -
> if (ASIC_IS_NODCE(rdev))
> goto check_memsize;
>
next prev parent reply other threads:[~2013-05-23 8:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-22 17:38 [PATCH] drm/radeon: revert Apple re-POST hack alexdeucher
2013-05-23 8:13 ` Christian König [this message]
2013-05-29 16:24 ` [PATCH] drm/radeon: narrow scope of " alexdeucher
2013-05-29 16:31 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=519DCFA3.6060706@vodafone.de \
--to=deathsimple@vodafone.de \
--cc=alexander.deucher@amd.com \
--cc=alexdeucher@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=mjg59@srcf.ucam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox