From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Furniss Subject: Re: [PATCH] drm/edid: Add both 60Hz and 59.94Hz CEA modes to connector's mode list Date: Tue, 18 Jun 2013 11:36:50 +0100 Message-ID: <51C03842.3060307@gmail.com> References: <1370003021-16594-1-git-send-email-ville.syrjala@linux.intel.com> <51C03216.80709@gmail.com> <20130618103033.GE5004@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1"; Format="flowed" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com [209.85.214.53]) by gabe.freedesktop.org (Postfix) with ESMTP id B8D07E60B3 for ; Tue, 18 Jun 2013 03:36:52 -0700 (PDT) Received: by mail-bk0-f53.google.com with SMTP id e11so1655543bkh.26 for ; Tue, 18 Jun 2013 03:36:51 -0700 (PDT) In-Reply-To: <20130618103033.GE5004@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: =?ISO-8859-1?Q?Ville_Syrj=E4l=E4?= Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org Ville Syrj=E4l=E4 wrote: > On Tue, Jun 18, 2013 at 11:10:30AM +0100, Andy Furniss wrote: >> ville.syrjala@linux.intel.com wrote: >>> From: Ville Syrj=E4l=E4 >>> >>> Having both modes can be beneficial for video playback cases. If you can >>> match the video framerate exactly, and the audio and video clocks come >>> from the same source, you should be able to avoid dropped/repeated >>> frames without expensive operations such as resampling the audio to >>> match video output rate. >>> >>> Rather than add both variants based on the CEA extension short video >>> descriptors in do_cea_modes(), add only one variant there. Once all >>> the EDID has been fully probed, do a loop over the entire probed mode >>> list, during which we add the other variants for all modes that match >>> CEA modes. This allows us to match modes that didn't come via the CEA >>> short video descriptors. For example one Samsung TV here doesn't have >>> the 640x480-60 mode as a SVD, but instead it's specified via a detailed >>> timing descriptor. >>> >>> Signed-off-by: Ville Syrj=E4l=E4 >>> --- >>> A few people requested this. Originally I was a bit opposed to it, but >>> when I thought about it a bit more I figured if the audio and video >>> clocks come from the same source (or happen to be close enough w/o >>> significant drift), this could provide a better A/V sync w/o resampling >>> tricks. >> >> I see this has gone in now, one thing I notice is that xorg/apps/xrandr >> only prints Hz to 1dp so you can't see which mode is which for the 24p >> and 30i cases. >> >> Maybe someone reading has commit access for xorg? > > Not sure if you noticed but I posted some relevant xrandr patches to > xorg-devel. Unfortunately I got no response, and I've been too lazy > to figure out who I need to pester. > Ahh, sorry I didn't see those, I just has a look at the current code to = check it was still the same.