From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
David Airlie <airlied@linux.ie>,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: move i915_trace_irq_get() out of the tracing macro
Date: Fri, 21 Jun 2013 14:51:07 +0200 [thread overview]
Message-ID: <51C44C3B.1090604@linutronix.de> (raw)
In-Reply-To: <20130621110849.GQ14531@cantiga.alporthouse.com>
On 06/21/2013 01:08 PM, Chris Wilson wrote:
> On Fri, Jun 21, 2013 at 12:15:53PM +0200, Sebastian Andrzej Siewior wrote:
>> There is a report on RT about "BUG: scheduling while atomic" because the
>> sleeping lock is taken in tracing context. This patch simply moves
>> locking operation out of the tracing macro.
>
> No. This enables the IRQ, as well as making a number of
> very expensively serialised read, unconditionally.
Ach in case CONFIG_TRACING is enabled but the tracepoint itself is
disabled. In that case it is probably best to drop this tracepoint from
-RT.
> -Chris
>
Sebastian
next prev parent reply other threads:[~2013-06-21 12:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-21 10:15 [PATCH] drm/i915: move i915_trace_irq_get() out of the tracing macro Sebastian Andrzej Siewior
2013-06-21 11:08 ` [Intel-gfx] " Chris Wilson
2013-06-21 12:51 ` Sebastian Andrzej Siewior [this message]
2013-06-24 7:31 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51C44C3B.1090604@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=airlied@linux.ie \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).