From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Lutomirski Subject: Re: [RFC 3/6] drm: add SimpleDRM driver Date: Mon, 24 Jun 2013 18:05:11 -0700 Message-ID: <51C8ECC7.4030404@mit.edu> References: <1372112849-670-1-git-send-email-dh.herrmann@gmail.com> <1372112849-670-4-git-send-email-dh.herrmann@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1372112849-670-4-git-send-email-dh.herrmann@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: David Herrmann Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Dave Airlie , linux-fbdev@vger.kernel.org, Stephen Warren , Olof Johansson List-Id: dri-devel@lists.freedesktop.org On 06/24/2013 03:27 PM, David Herrmann wrote: > + sdrm->fb_map = ioremap(sdrm->fb_base, sdrm->fb_size); This should probably be ioremap_wc. Otherwise it will be *really* slow if used in legacy mode and it may cause conflicts with the pgprot_writecombine mode for mmap. (Watching boot messages go by on fbcon on efifb was like using an old 2400 baud modem before I made the corresponding change to efifb.) --Andy