From: "Christian König" <christian.koenig@amd.com>
To: David Herrmann <dh.herrmann@gmail.com>
Cc: Alex Deucher <alexander.deucher@amd.com>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2 0/6] DRM: VMA Access Management and Render Nodes
Date: Fri, 23 Aug 2013 13:28:05 +0200 [thread overview]
Message-ID: <52174745.306@amd.com> (raw)
In-Reply-To: <1377256408-746-1-git-send-email-dh.herrmann@gmail.com>
Hi David,
Am 23.08.2013 13:13, schrieb David Herrmann:
> Hi
>
> I reduced the vma access-management patches to a minimum. I now do filp*
> tracking in gem unconditionally and force drm_gem_mmap() to check this. Hence,
> all gem drivers are safe now. For TTM drivers, I now use the already available
> verify_access() callback to get access to the underlying gem-object. Pretty
> simple.. Why hadn't I thought of that before?
>
> Long story short: All drivers using GEM are safe now. This leaves vmwgfx.. But
> they do their own access-management, anyway.
>
> The 3 patches on top implement render-nodes. I added a "drm_rnodes" module
> parameter to core drm. You need to pass "drm.rnodes=1" on the kernel
> command-line or via sysfs _before_ loading a driver. Otherwise, render nodes
> will not be created.
>
> This allows us to test render-nodes and play with the API. I added FLINK for
> now so we can better test it. Not sure whether we should allow it in the end,
> though.
>
> Maybe we can get this into 3.11?
A bit unlikely, but 3.12 should work fine.
I'm working on a project that can make good use of this, so if Alex
doesn't mind like to add the necessary radeon flags (should be only a
few one liners anyway).
Cheers,
Christian.
> Regards
> David
>
> David Herrmann (4):
> drm/vma: add access management helpers
> drm/gem: implement vma access management
> drm: verify vma access in TTM+GEM drivers
> drm: implement experimental render nodes
>
> Kristian Høgsberg (1):
> drm/i915: Support render nodes
>
> Martin Peres (1):
> drm/nouveau: Support render nodes
>
> Documentation/DocBook/drm.tmpl | 71 ++++++++++++++++
> drivers/gpu/drm/ast/ast_ttm.c | 4 +-
> drivers/gpu/drm/cirrus/cirrus_ttm.c | 4 +-
> drivers/gpu/drm/drm_drv.c | 15 ++--
> drivers/gpu/drm/drm_fops.c | 14 +--
> drivers/gpu/drm/drm_gem.c | 18 ++++
> drivers/gpu/drm/drm_pci.c | 9 ++
> drivers/gpu/drm/drm_platform.c | 9 ++
> drivers/gpu/drm/drm_stub.c | 10 +++
> drivers/gpu/drm/drm_usb.c | 9 ++
> drivers/gpu/drm/drm_vma_manager.c | 155 ++++++++++++++++++++++++++++++++++
> drivers/gpu/drm/i915/i915_dma.c | 36 ++++----
> drivers/gpu/drm/i915/i915_drv.c | 3 +-
> drivers/gpu/drm/mgag200/mgag200_ttm.c | 4 +-
> drivers/gpu/drm/nouveau/nouveau_bo.c | 4 +-
> drivers/gpu/drm/nouveau/nouveau_drm.c | 24 +++---
> drivers/gpu/drm/qxl/qxl_ttm.c | 4 +-
> drivers/gpu/drm/radeon/radeon_ttm.c | 4 +-
> include/drm/drmP.h | 9 ++
> include/drm/drm_vma_manager.h | 21 ++++-
> 20 files changed, 373 insertions(+), 54 deletions(-)
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2013-08-23 11:43 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-23 11:13 [PATCH v2 0/6] DRM: VMA Access Management and Render Nodes David Herrmann
2013-08-23 11:13 ` [PATCH v2 1/6] drm/vma: add access management helpers David Herrmann
2013-08-23 11:13 ` [PATCH v2 2/6] drm/gem: implement vma access management David Herrmann
2013-08-23 11:13 ` [PATCH v2 3/6] drm: verify vma access in TTM+GEM drivers David Herrmann
2013-08-23 11:13 ` [PATCH v2 4/6] drm: implement experimental render nodes David Herrmann
2013-08-23 11:13 ` [PATCH v2 5/6] drm/i915: Support " David Herrmann
2013-08-23 11:29 ` Chris Wilson
2013-08-23 21:13 ` Kristian Høgsberg
2013-08-23 22:51 ` Daniel Vetter
2013-08-23 11:13 ` [PATCH v2 6/6] drm/nouveau: " David Herrmann
2013-08-23 11:28 ` Christian König [this message]
2013-08-23 12:31 ` [PATCH v2 0/6] DRM: VMA Access Management and Render Nodes David Herrmann
2013-08-23 12:34 ` Christian König
2013-08-23 12:47 ` David Herrmann
2013-08-23 13:34 ` Alex Deucher
2013-08-23 12:00 ` Martin Peres
2013-08-25 15:09 ` David Herrmann
2013-08-25 18:22 ` Martin Peres
2013-08-25 16:28 ` [PATCH 1/7] drm/vma: add access management helpers David Herrmann
2013-08-25 16:28 ` [PATCH 2/7] drm/gem: implement vma access management David Herrmann
2013-08-25 16:28 ` [PATCH 3/7] drm: verify vma access in TTM+GEM drivers David Herrmann
2013-08-25 16:29 ` [PATCH 4/7] drm: implement experimental render nodes David Herrmann
2013-08-25 16:29 ` [PATCH 5/7] drm/i915: Support " David Herrmann
2013-08-25 16:29 ` [PATCH 6/7] drm/nouveau: " David Herrmann
2013-08-25 16:29 ` [PATCH 7/7] drm/radeon: support " David Herrmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52174745.306@amd.com \
--to=christian.koenig@amd.com \
--cc=alexander.deucher@amd.com \
--cc=dh.herrmann@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox