From: Thomas Hellstrom <thellstrom@vmware.com>
To: "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>
Subject: Pairing drm_prime_handle_from_fd with close
Date: Fri, 08 Nov 2013 11:02:37 +0100 [thread overview]
Message-ID: <527CB6BD.4000702@vmware.com> (raw)
Hi!
It seems like prime_handle_from_fd needs to be paired with a GEM_CLOSE
ioctl instead of a new generic HANDLE_CLOSE ioctl.
This oversight is not really a big problem but there are two solutions:
1) Create a new ioctl called HANDLE_CLOSE or something similar.
2) Use the GEM_CLOSE ioctl, but add a driver callback for drivers that
are not GEM-aware.
It seems like GEM_CLOSE has already spread into user-space clients, so
unless someone tell me otherwise, I'll be using
2) for the vmwgfx prime implementation.
Thanks,
Thomas
next reply other threads:[~2013-11-08 10:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-08 10:02 Thomas Hellstrom [this message]
2013-11-08 17:19 ` Pairing drm_prime_handle_from_fd with close Daniel Vetter
2013-11-08 17:38 ` Thomas Hellstrom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=527CB6BD.4000702@vmware.com \
--to=thellstrom@vmware.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox