From: Jyri Sarha <jsarha@ti.com>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>, Rob Herring <robh@kernel.org>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Tony Lindgren <tony@atomide.com>,
dri-devel <dri-devel@lists.freedesktop.org>,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
Karl Beldan <kbeldan@baylibre.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Benoit Cousson <bcousson@baylibre.com>
Subject: Re: [PATCH v2 2/7] drm/tilcdc: Add blue-and-red-crossed devicetree property
Date: Tue, 30 Aug 2016 15:54:12 +0300 [thread overview]
Message-ID: <5289ced6-8bb6-e71b-365b-c2ff66487c5b@ti.com> (raw)
In-Reply-To: <d488f8b8-0a16-3554-4cb4-cf5fdcbf7840@ti.com>
On 08/30/16 15:46, Tomi Valkeinen wrote:
>
>
> On 26/08/16 20:44, Jyri Sarha wrote:
>> On 08/26/16 15:51, Rob Herring wrote:
>>>> --- a/Documentation/devicetree/bindings/display/tilcdc/tilcdc.txt
>>>>> +++ b/Documentation/devicetree/bindings/display/tilcdc/tilcdc.txt
>>>>> @@ -17,6 +17,8 @@ Optional properties:
>>>>> the lcd controller.
>>>>> - max-pixelclock: The maximum pixel clock that can be supported
>>>>> by the lcd controller in KHz.
>>>>> + - blue-and-red-crossed: Boolean property, set this of blue and red wires
>>>>> + for LCD_DATA are crossed for 24-bit RGB support (and 16-bit BGR mode). [1]
>>> Doesn't this need to be blue-and-red-straight for compatibility?
>>>
>>
>> There is no way to be backward compatible with all am3 based devices.
>
> Hmm, I guess it would be possible to have three options:
>
> - No property set: driver advertises RG16 and RG24. This is wrong, but
> that's what the current status is, right?
> - Property set to "default" or "straight" or whatever: driver says RG16
> and BG24
> - Property set to "crossed": driver says BG16 and RG24
>
Yes, that would be backward compatible and probably the best approach.
As this way all applications would still run, even if the colours are
wrong (as they have always been).
I'll do that if no one suggests otherwise.
BR,
Jyri
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-08-30 12:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-25 12:03 [PATCH v2 0/7] drm/tilcdc: Address LCDC rev 2 color errata Jyri Sarha
2016-08-25 12:03 ` [PATCH v2 1/7] drm/tilcdc: Remove drm_helper_disable_unused_functions() call Jyri Sarha
2016-08-25 12:03 ` [PATCH v2 2/7] drm/tilcdc: Add blue-and-red-crossed devicetree property Jyri Sarha
2016-08-26 12:51 ` Rob Herring
2016-08-26 17:44 ` Jyri Sarha
[not found] ` <f4f9d53e-bc9a-6b88-7fe4-3f3015abfdb5-l0cyMroinI0@public.gmane.org>
2016-08-30 12:46 ` Tomi Valkeinen
2016-08-30 12:54 ` Jyri Sarha [this message]
2016-08-25 12:03 ` [PATCH v2 3/7] drm/tilcdc: Choose console BPP that supports RGB Jyri Sarha
2016-08-25 12:03 ` [PATCH v2 4/7] ARM: dts: am335x-boneblack: Add comments on how to support 24 bit RGB mode Jyri Sarha
2016-08-25 12:03 ` [PATCH v2 5/7] ARM: dts: am335x-evm: Add blue-and-red-crossed -property to lcdc node Jyri Sarha
2016-08-25 12:03 ` [PATCH v2 6/7] ARM: dts: am335x-evmsk: Whitespace cleanup of lcdc related nodes Jyri Sarha
2016-08-25 12:03 ` [PATCH v2 7/7] ARM: dts: am335x-evmsk: Add blue-and-red-crossed -property to lcdc node Jyri Sarha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5289ced6-8bb6-e71b-365b-c2ff66487c5b@ti.com \
--to=jsarha@ti.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=kbeldan@baylibre.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=peter.ujfalusi@ti.com \
--cc=robh@kernel.org \
--cc=tomi.valkeinen@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox