From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kenneth Graunke <kenneth@whitecape.org>
Subject: Re: [PATCH 1/4] dri3: Clean up struct dri3_drawable
Date: Fri, 13 Dec 2013 15:01:51 -0800
Message-ID: <52AB91DF.9020107@whitecape.org>
References: <86ob5751ju.fsf@miki.keithp.com>	<1385444155-15506-1-git-send-email-keithp@keithp.com>
	<1385444155-15506-2-git-send-email-keithp@keithp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <mesa-dev-bounces@lists.freedesktop.org>
In-Reply-To: <1385444155-15506-2-git-send-email-keithp@keithp.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/mesa-dev>,
	<mailto:mesa-dev-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/mesa-dev>
List-Post: <mailto:mesa-dev@lists.freedesktop.org>
List-Help: <mailto:mesa-dev-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/mesa-dev>,
	<mailto:mesa-dev-request@lists.freedesktop.org?subject=subscribe>
Sender: mesa-dev-bounces@lists.freedesktop.org
Errors-To: mesa-dev-bounces@lists.freedesktop.org
To: Keith Packard <keithp@keithp.com>, mesa-dev@lists.freedesktop.org, Eric Anholt <eric@anholt.net>
Cc: dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

On 11/25/2013 09:35 PM, Keith Packard wrote:
> Move the depth field up with width and height.
> 
> Remove unused previous_time and frames fields.
> 
> Signed-off-by: Keith Packard <keithp@keithp.com>
> ---
>  src/glx/dri3_priv.h | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/src/glx/dri3_priv.h b/src/glx/dri3_priv.h
> index 05f66cf..34c67a6 100644
> --- a/src/glx/dri3_priv.h
> +++ b/src/glx/dri3_priv.h
> @@ -177,7 +177,7 @@ dri3_pixmap_buf_id(enum dri3_buffer_type buffer_type)
>  struct dri3_drawable {
>     __GLXDRIdrawable base;
>     __DRIdrawable *driDrawable;
> -   int width, height;
> +   int width, height, depth;
>     int swap_interval;
>     uint8_t have_back;
>     uint8_t have_fake_front;
> @@ -193,13 +193,9 @@ struct dri3_drawable {
>     /* For WaitMSC */
>     uint32_t present_msc_request_serial;
>     uint32_t present_msc_event_serial;
> -   
> -   uint64_t previous_time;
> -   unsigned frames;
>  
>     struct dri3_buffer *buffers[DRI3_NUM_BUFFERS];
>     int cur_back;
> -   int depth;
>  
>     uint32_t *stamp;
>  
> 

This one is easy.
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>

I plan to push it - hopefully today.  I don't feel qualified to review
the SBC and swap event handling patches, so hopefully someone else can
take a look...