Re: [RFC v2 0/3] DRM Anonymous Inodes

[Thomas Hellstrom <thellstrom@vmware.com>]

David,

I haven't had time to test on vmwgfx yet, but looking through the code
it looks good to me.

Acked-by: Thomas Hellstrom <thellstrom@vmware.com>

/Thomas

On 01/16/2014 12:29 PM, David Herrmann wrote:
> Hi
>
> On Fri, Jan 3, 2014 at 3:41 PM, David Herrmann <dh.herrmann@gmail.com> wrote:
>> Hi
>>
>> With 3.13-rc1 the required VFS core changes for anonymous backing inodes in DRM
>> got merged. This series reworks the previous patches (I think from early
>> August '13) and finally replaces the ugly drm_device->dev_mapping hack.
>>
>> The patches should be fairly obvious. As I currently only have nouveau here, I'd
>> be happy to get some more testers with other drivers.
>>
>> Patch #1 adds an internal private mount point to DRM core.
>> Patch #2 replaces ->dev_mapping with a private anonymous inode for each device.
>> Patch #3 removes the delayed dev_mapping initialization in TTM.
>>
>> The internal mnt-point is based on fs/aio.c and fs/anon_inode.c which do the
>> same. It's not clear to me why we cannot share the mnt-point between all these,
>> but Al Viro made clear that he will reject any patches on anon_inode.c which do
>> that. So lets follow his recommendation and use our own internal mnt-point.
> Also tested on i915 ivb now (before: nouveau+TTM). I think this is
> ready for 3.14 if nobody finds any issues.
>
> Thanks
> David
>
>> Thanks
>> David
>>
>> David Herrmann (3):
>>   drm: add pseudo filesystem for shared inodes
>>   drm: use anon-inode instead of relying on cdevs
>>   drm: init TTM dev_mapping in ttm_bo_device_init()
>>
>>  drivers/gpu/drm/ast/ast_ttm.c          |  5 +++--
>>  drivers/gpu/drm/cirrus/cirrus_ttm.c    |  5 +++--
>>  drivers/gpu/drm/drm_drv.c              | 37 ++++++++++++++++++++++++++++++++++
>>  drivers/gpu/drm/drm_fops.c             | 25 +++--------------------
>>  drivers/gpu/drm/drm_stub.c             | 12 ++++++++++-
>>  drivers/gpu/drm/i915/i915_gem.c        |  3 ++-
>>  drivers/gpu/drm/mgag200/mgag200_ttm.c  |  5 +++--
>>  drivers/gpu/drm/nouveau/nouveau_gem.c  |  2 --
>>  drivers/gpu/drm/nouveau/nouveau_ttm.c  |  4 +++-
>>  drivers/gpu/drm/omapdrm/omap_gem.c     | 34 +++++++++++++++----------------
>>  drivers/gpu/drm/qxl/qxl_object.c       |  2 --
>>  drivers/gpu/drm/qxl/qxl_ttm.c          |  6 +++---
>>  drivers/gpu/drm/radeon/radeon_object.c |  1 -
>>  drivers/gpu/drm/radeon/radeon_ttm.c    |  5 +++--
>>  drivers/gpu/drm/ttm/ttm_bo.c           |  3 ++-
>>  drivers/gpu/drm/vmwgfx/vmwgfx_drv.c    |  5 +++--
>>  include/drm/drmP.h                     |  3 ++-
>>  include/drm/drm_vma_manager.h          |  6 +++---
>>  include/drm/ttm/ttm_bo_driver.h        |  2 ++
>>  19 files changed, 100 insertions(+), 65 deletions(-)
>>
>> --
>> 1.8.5.2
>>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel