From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Hellstrom <thomas@shipmail.org>
Subject: Re: [PATCH] drm/ttm: Fix memory leak in ttm_agp_backend.c
Date: Thu, 13 Feb 2014 13:10:38 +0100
Message-ID: <52FCB63E.1080601@shipmail.org>
References: <1392212785-23150-1-git-send-email-standby24x7@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from mx1.bahnhof.se (mx1.bahnhof.se [213.80.101.11])
	by gabe.freedesktop.org (Postfix) with ESMTP id 87FE9FA50F
	for <dri-devel@lists.freedesktop.org>;
	Thu, 13 Feb 2014 04:10:49 -0800 (PST)
In-Reply-To: <1392212785-23150-1-git-send-email-standby24x7@gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: dri-devel-bounces@lists.freedesktop.org
Errors-To: dri-devel-bounces@lists.freedesktop.org
To: Masanari Iida <standby24x7@gmail.com>
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

On 02/12/2014 02:46 PM, Masanari Iida wrote:
> This patch fix a memory leak found by cppcheck.
> [drivers/gpu/drm/ttm/ttm_agp_backend.c:129]:
> (error) Memory leak: agp_be
>
> Signed-off-by: Masanari Iida <standby24x7@gmail.com>
> ---
>  drivers/gpu/drm/ttm/ttm_agp_backend.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/ttm/ttm_agp_backend.c b/drivers/gpu/drm/ttm/ttm_agp_backend.c
> index 3302f99..764be36 100644
> --- a/drivers/gpu/drm/ttm/ttm_agp_backend.c
> +++ b/drivers/gpu/drm/ttm/ttm_agp_backend.c
> @@ -126,6 +126,7 @@ struct ttm_tt *ttm_agp_tt_create(struct ttm_bo_device *bdev,
>  	agp_be->ttm.func = &ttm_agp_func;
>  
>  	if (ttm_tt_init(&agp_be->ttm, bdev, size, page_flags, dummy_read_page)) {
> +		kfree(agp_be);
>  		return NULL;
>  	}
>  

Thanks, I'll include in the next ttm-fixes pull request.

/Thomas