From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Marijn Suijten <marijn.suijten@somainline.org>
Cc: Michael Turquette <mturquette@baylibre.com>,
dri-devel@lists.freedesktop.org,
Krishna Manikandan <quic_mkrishn@quicinc.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-clk@vger.kernel.org, Krzysztof Kozlowski <krzk@kernel.org>,
Andy Gross <agross@kernel.org>, Lux Aliaga <they@mint.lgbt>,
devicetree@vger.kernel.org, Conor Dooley <conor+dt@kernel.org>,
linux-arm-msm@vger.kernel.org,
Abhinav Kumar <quic_abhinavk@quicinc.com>,
Rob Herring <robh+dt@kernel.org>,
Martin Botka <martin.botka@somainline.org>,
~postmarketos/upstreaming@lists.sr.ht,
Sean Paul <sean@poorly.run>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Stephen Boyd <sboyd@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
linux-kernel@vger.kernel.org,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Jami Kettunen <jami.kettunen@somainline.org>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
freedreno@lists.freedesktop.org
Subject: Re: [PATCH 03/15] dt-bindings: clock: qcom, dispcc-sm6125: Require GCC PLL0 DIV clock
Date: Mon, 26 Jun 2023 18:10:44 +0200 [thread overview]
Message-ID: <52c57cab-10cf-2e7e-2c1d-fa6506786d45@linaro.org> (raw)
In-Reply-To: <vnp263d43flny2ibt3n7fbloyi26enqrejnobogplfu5fcj6l3@s7zkxrsi2rde>
On 25/06/2023 21:48, Marijn Suijten wrote:
> On 2023-06-24 11:08:54, Krzysztof Kozlowski wrote:
>> On 24/06/2023 03:45, Konrad Dybcio wrote:
>>> On 24.06.2023 02:41, Marijn Suijten wrote:
>>>> The "gcc_disp_gpll0_div_clk_src" clock is consumed by the driver, will
>>>> be passed from DT, and should be required by the bindings.
>>>>
>>>> Fixes: 8397c9c0c26b ("dt-bindings: clock: add QCOM SM6125 display clock bindings")
>>>> Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org>
>>>> ---
>>> Ideally, you'd stick it at the bottom of the list, as the items: order
>>> is part of the ABI
>>
>> Yes, please add them to the end. Order is fixed.
>
> Disagreed for bindings that declare clock-names and when the driver
> adheres to it, see my reply to Konrad's message.
That's the generic rule, with some exceptions of course. Whether one
chosen driver (chosen system and chosen version of that system) adheres
or not, does not change it. Other driver behaves differently and ABI is
for everyone, not only for your specific version of Linux driver.
Follow the rule.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-06-26 16:10 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-24 0:40 [PATCH 00/15] drm/msm: Add SM6125 MDSS/DPU hardware and enable Sony Xperia 10 II panel Marijn Suijten
2023-06-24 0:40 ` [PATCH 01/15] arm64: dts: qcom: sm6125: Sort spmi_bus node numerically by reg Marijn Suijten
2023-06-24 1:43 ` Konrad Dybcio
2023-06-25 19:10 ` Marijn Suijten
2023-06-24 0:41 ` [PATCH 02/15] dt-bindings: clock: qcom,dispcc-sm6125: Remove unused GCC_DISP_AHB_CLK Marijn Suijten
2023-06-24 9:08 ` Krzysztof Kozlowski
2023-06-25 19:44 ` Marijn Suijten
2023-06-24 0:41 ` [PATCH 03/15] dt-bindings: clock: qcom,dispcc-sm6125: Require GCC PLL0 DIV clock Marijn Suijten
2023-06-24 1:45 ` [PATCH 03/15] dt-bindings: clock: qcom, dispcc-sm6125: " Konrad Dybcio
2023-06-24 9:08 ` Krzysztof Kozlowski
2023-06-25 19:48 ` [PATCH 03/15] dt-bindings: clock: qcom,dispcc-sm6125: " Marijn Suijten
2023-06-26 16:10 ` Krzysztof Kozlowski [this message]
2023-06-26 17:49 ` Marijn Suijten
2023-06-26 18:29 ` [PATCH 03/15] dt-bindings: clock: qcom, dispcc-sm6125: " Krzysztof Kozlowski
2023-06-26 18:51 ` [PATCH 03/15] dt-bindings: clock: qcom,dispcc-sm6125: " Marijn Suijten
2023-06-26 18:53 ` Marijn Suijten
2023-06-27 6:24 ` [PATCH 03/15] dt-bindings: clock: qcom, dispcc-sm6125: " Krzysztof Kozlowski
2023-06-27 6:54 ` [PATCH 03/15] dt-bindings: clock: qcom,dispcc-sm6125: " Marijn Suijten
2023-06-27 7:29 ` [PATCH 03/15] dt-bindings: clock: qcom, dispcc-sm6125: " Krzysztof Kozlowski
2023-06-27 7:49 ` [PATCH 03/15] dt-bindings: clock: qcom,dispcc-sm6125: " Marijn Suijten
2023-06-27 8:21 ` [PATCH 03/15] dt-bindings: clock: qcom, dispcc-sm6125: " Krzysztof Kozlowski
2023-06-27 9:02 ` [PATCH 03/15] dt-bindings: clock: qcom,dispcc-sm6125: " Marijn Suijten
2023-06-27 9:07 ` [PATCH 03/15] dt-bindings: clock: qcom, dispcc-sm6125: " Krzysztof Kozlowski
2023-06-27 9:11 ` [PATCH 03/15] dt-bindings: clock: qcom,dispcc-sm6125: " Marijn Suijten
2023-06-25 19:48 ` Marijn Suijten
2023-06-26 9:43 ` [PATCH 03/15] dt-bindings: clock: qcom, dispcc-sm6125: " Konrad Dybcio
2023-06-26 14:26 ` [PATCH 03/15] dt-bindings: clock: qcom,dispcc-sm6125: " Marijn Suijten
2023-06-26 16:15 ` [PATCH 03/15] dt-bindings: clock: qcom, dispcc-sm6125: " Krzysztof Kozlowski
2023-06-26 17:47 ` [PATCH 03/15] dt-bindings: clock: qcom,dispcc-sm6125: " Marijn Suijten
2023-06-24 0:41 ` [PATCH 04/15] dt-bindings: clock: qcom,dispcc-sm6125: Allow power-domains property Marijn Suijten
2023-06-24 9:10 ` Krzysztof Kozlowski
2023-06-24 0:41 ` [PATCH 05/15] dt-bindings: display/msm: dsi-controller-main: Document SM6125 Marijn Suijten
2023-06-24 9:11 ` Krzysztof Kozlowski
2023-06-24 0:41 ` [PATCH 06/15] dt-bindings: display/msm: sc7180-dpu: Describe SM6125 Marijn Suijten
2023-06-24 9:12 ` Krzysztof Kozlowski
2023-06-25 19:52 ` Marijn Suijten
2023-06-26 16:16 ` Krzysztof Kozlowski
2023-06-26 17:54 ` Marijn Suijten
2023-06-26 18:57 ` Konrad Dybcio
2023-06-26 20:28 ` Marijn Suijten
2023-06-26 22:46 ` Konrad Dybcio
2023-06-26 14:04 ` Dmitry Baryshkov
2023-06-28 20:27 ` [Freedreno] " Abhinav Kumar
2023-06-24 0:41 ` [PATCH 07/15] dt-bindings: display/msm: Add SM6125 MDSS Marijn Suijten
2023-06-24 2:03 ` Rob Herring
2023-06-24 9:31 ` Krzysztof Kozlowski
2023-06-24 0:41 ` [PATCH 08/15] drm/msm/dpu: Add SM6125 support Marijn Suijten
2023-06-24 1:47 ` Konrad Dybcio
2023-06-25 20:19 ` Marijn Suijten
2023-06-26 9:37 ` Konrad Dybcio
2023-06-24 0:41 ` [PATCH 09/15] drm/msm/mdss: " Marijn Suijten
2023-06-27 8:49 ` Dmitry Baryshkov
2023-06-27 9:06 ` Marijn Suijten
2023-06-24 0:41 ` [PATCH 10/15] dt-bindings: msm: dsi-phy-14nm: Document SM6125 variant Marijn Suijten
2023-06-24 9:33 ` Krzysztof Kozlowski
2023-06-24 13:48 ` Dmitry Baryshkov
2023-06-25 7:16 ` Krzysztof Kozlowski
2023-06-24 0:41 ` [PATCH 11/15] drm/msm/dsi: Add 14nm phy configuration for SM6125 Marijn Suijten
2023-06-24 1:49 ` Konrad Dybcio
2023-06-24 13:51 ` Dmitry Baryshkov
2023-06-25 20:23 ` Marijn Suijten
2023-06-26 9:50 ` Konrad Dybcio
2023-06-24 0:41 ` [PATCH 12/15] arm64: dts: qcom: sm6125: Switch fixed xo_board clock to RPM XO clock Marijn Suijten
2023-06-24 1:50 ` Konrad Dybcio
2023-06-24 0:41 ` [PATCH 13/15] arm64: dts: qcom: sm6125: Add dispcc node Marijn Suijten
2023-06-24 1:53 ` Konrad Dybcio
2023-06-24 13:52 ` Dmitry Baryshkov
2023-06-24 0:41 ` [PATCH 14/15] arm64: dts: qcom: sm6125: Add display hardware nodes Marijn Suijten
2023-06-24 2:05 ` Konrad Dybcio
2023-06-25 19:36 ` Marijn Suijten
2023-06-24 0:41 ` [PATCH 15/15] arm64: dts: qcom: sm6125-seine: Configure MDSS, DSI and panel Marijn Suijten
2023-06-24 2:06 ` Konrad Dybcio
2023-06-25 19:41 ` Marijn Suijten
2023-06-24 1:42 ` [PATCH 00/15] drm/msm: Add SM6125 MDSS/DPU hardware and enable Sony Xperia 10 II panel Konrad Dybcio
2023-06-25 19:18 ` Marijn Suijten
2023-06-26 9:41 ` Konrad Dybcio
2023-06-26 14:17 ` Marijn Suijten
2023-06-26 14:20 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52c57cab-10cf-2e7e-2c1d-fa6506786d45@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jami.kettunen@somainline.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzk@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=martin.botka@somainline.org \
--cc=mturquette@baylibre.com \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_mkrishn@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=sean@poorly.run \
--cc=they@mint.lgbt \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).