From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maarten Lankhorst Subject: Re: [PATCH] nouveau, ACPI: fix regression caused by b072e53 Date: Wed, 19 Feb 2014 11:12:27 +0100 Message-ID: <5304838B.4040500@canonical.com> References: <1392785628-30633-1-git-send-email-jiang.liu@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by gabe.freedesktop.org (Postfix) with ESMTP id 2A362FABA3 for ; Wed, 19 Feb 2014 02:12:32 -0800 (PST) In-Reply-To: <1392785628-30633-1-git-send-email-jiang.liu@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org To: Jiang Liu , David Airlie , "Rafael J. Wysocki" , Dave Airlie , Emil Velikov Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org op 19-02-14 05:53, Jiang Liu schreef: > On some platforms, ACPI _DSM method (nouveau_op_dsm_muid, function 0) > has special requirements on the fourth parameter, which is different > from ACPI specifications. So revert to the private implementation > to check availability of _DSM functions instead of using common > acpi_check_dsm() interface. > > Signed-off-by: Jiang Liu > --- > Hi Maarten, > Thanks for bisecting. Could you please help to verify whether > this patch fixes the regression? > Tested-by: Maarten Lankhorst I was wrong about the operator precedence, seems correct after all. :-)