From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Romanick <idr@freedesktop.org>
Subject: Re: [PATCH 02/13] drm/mgag200: Remove unecessary NULL check in
 gem_free
Date: Mon, 07 Apr 2014 08:23:43 -0700
Message-ID: <5342C2FF.1090004@freedesktop.org>
References: <1396691102-22904-1-git-send-email-daniel.vetter@ffwll.ch>
 <1396691102-22904-4-git-send-email-daniel.vetter@ffwll.ch>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from q7.q7.com (q7.q7.com [69.168.48.248])
 by gabe.freedesktop.org (Postfix) with ESMTP id 17CCC6E6C8
 for <dri-devel@lists.freedesktop.org>; Mon,  7 Apr 2014 08:23:46 -0700 (PDT)
In-Reply-To: <1396691102-22904-4-git-send-email-daniel.vetter@ffwll.ch>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Daniel Vetter <daniel.vetter@ffwll.ch>, DRI Development <dri-devel@lists.freedesktop.org>
Cc: Dave Jones <davej@redhat.com>
List-Id: dri-devel@lists.freedesktop.org

On 04/05/2014 02:44 AM, Daniel Vetter wrote:
> The ->gem_free_object never gets called with a NULL pointer, the check
> is redundant. Also checking after the upcast allows compilers to elide
> it anyway.

Right... because if obj was NULL, subtracting some offset from it won't
still be NULL.

> Spotted by coverity.
> 
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>

> ---
>  drivers/gpu/drm/mgag200/mgag200_main.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/mgag200/mgag200_main.c b/drivers/gpu/drm/mgag200/mgag200_main.c
> index 0722d18992f4..f6b283b8375e 100644
> --- a/drivers/gpu/drm/mgag200/mgag200_main.c
> +++ b/drivers/gpu/drm/mgag200/mgag200_main.c
> @@ -329,8 +329,6 @@ void mgag200_gem_free_object(struct drm_gem_object *obj)
>  {
>  	struct mgag200_bo *mgag200_bo = gem_to_mga_bo(obj);
>  
> -	if (!mgag200_bo)
> -		return;
>  	mgag200_bo_unref(&mgag200_bo);
>  }
>  
>