From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Romanick <idr@freedesktop.org>
Subject: Re: [PATCH 08/13] drm/ast: Remove dead code from cbr_scan2
Date: Mon, 07 Apr 2014 08:28:02 -0700
Message-ID: <5342C402.3070305@freedesktop.org>
References: <1396691102-22904-1-git-send-email-daniel.vetter@ffwll.ch>
 <1396691102-22904-10-git-send-email-daniel.vetter@ffwll.ch>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from q7.q7.com (q7.q7.com [69.168.48.248])
 by gabe.freedesktop.org (Postfix) with ESMTP id 9CB256E6CE
 for <dri-devel@lists.freedesktop.org>; Mon,  7 Apr 2014 08:28:07 -0700 (PDT)
In-Reply-To: <1396691102-22904-10-git-send-email-daniel.vetter@ffwll.ch>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Daniel Vetter <daniel.vetter@ffwll.ch>, DRI Development <dri-devel@lists.freedesktop.org>
Cc: Dave Jones <davej@redhat.com>, Dave Airlie <airlied@redhat.com>
List-Id: dri-devel@lists.freedesktop.org

On 04/05/2014 02:44 AM, Daniel Vetter wrote:
> The outer if already checks for data != 0, so it can't really be
> 0. Hence remove it.
> 
> Now I don't have specs or anything for this beast, so I have no
> idea whether this was actually intended or whether the logic
> should be different. At least the code still seems to be doing
> something useful.
> 
> Spotted by coverity.
> 
> Cc: Dave Airlie <airlied@redhat.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
>  drivers/gpu/drm/ast/ast_post.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/ast/ast_post.c b/drivers/gpu/drm/ast/ast_post.c
> index 977cfb35837a..6263116054b6 100644
> --- a/drivers/gpu/drm/ast/ast_post.c
> +++ b/drivers/gpu/drm/ast/ast_post.c
> @@ -572,8 +572,6 @@ static u32 cbr_scan2(struct ast_private *ast)
>  		for (loop = 0; loop < CBR_PASSNUM2; loop++) {
>  			if ((data = cbr_test2(ast)) != 0) {
>  				data2 &= data;
> -				if (!data)
> -					return 0;

That feels like a typo... was that supposed to be 'if (!data2)'?

>  				break;
>  			}
>  		}
>