Re: [PATCH 11/13] drm/bochs: Remove unecessary NULL check in gem_free

[Ian Romanick <idr@freedesktop.org>]

On 04/05/2014 02:45 AM, Daniel Vetter wrote:
> The ->gem_free_object never gets called with a NULL pointer, the check
> is redundant. Also checking after the upcast allows compilers to elide
> it anyway.
> 
> Noticed while chasing coverity reports, somehow this one here was not
> flagged.
> 
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

Same as MGA change.

Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>

> ---
>  drivers/gpu/drm/bochs/bochs_mm.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/bochs/bochs_mm.c b/drivers/gpu/drm/bochs/bochs_mm.c
> index 4a239e931aff..b9a695d92792 100644
> --- a/drivers/gpu/drm/bochs/bochs_mm.c
> +++ b/drivers/gpu/drm/bochs/bochs_mm.c
> @@ -441,8 +441,6 @@ void bochs_gem_free_object(struct drm_gem_object *obj)
>  {
>  	struct bochs_bo *bochs_bo = gem_to_bochs_bo(obj);
>  
> -	if (!bochs_bo)
> -		return;
>  	bochs_bo_unref(&bochs_bo);
>  }
>  
>