dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Hellstrom <thellstrom@vmware.com>
To: David Herrmann <dh.herrmann@gmail.com>
Cc: "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>
Subject: Re: WARNING ... drivers/gpu/drm/ttm/ttm_bo_vm.c...
Date: Wed, 09 Apr 2014 21:21:27 +0200	[thread overview]
Message-ID: <53459DB7.7040402@vmware.com> (raw)
In-Reply-To: <CANq1E4Q9G9O3x2JbxynuXpQBkqF9haOS-zbNvF6Sdifr=476sg@mail.gmail.com>

Hi, David!

Thanks for the reply.

Actually I just got CC'd on the Fedora Bug. I haven't seen this either,
so I can't provide more info...

What I was thinking was that maybe after a fork, vma->vm_file->f_mapping
of the child process wasn't set to the same value as the
parent...

/Thomas



On 04/09/2014 08:54 PM, David Herrmann wrote:
> Hi Thomas
>
> On Tue, Apr 8, 2014 at 7:11 AM, Thomas Hellstrom <thellstrom@vmware.com> wrote:
>> Hi, David,
>>
>> Are there any dev_mapping changes in 3.15 that could cause this?
>> Do we know what happens to vma->vm_file->f_mapping during fork?
> Sorry, I was traveling. Yes, there have been changes, but I converted
> all drivers properly. We now set file->f_mapping in drm_fops.c to
> dev->anon_inode->i_mapping during open(). All the ttm stuff now sets
> ttm->dev_mapping to the same during ttm init so I have no idea why
> that assertion fails. The vmwgfx driver sets it correctly in
> vmw_driver_load() and I cannot find any code changing it.
>
> I also cannot reproduce it. Can you provide some more information?
> Like what is vma->vm_file set to? What is ttm->dev_mapping? What is
> drm_device->anon_inode->i_mapping? What is
> &drm_device->anon_inode->i_data? All these should _always_ be the
> same.
>
> Btw., grep'ping for '_mapping' usually shows all related code, which I
> reviewed and all looks good.
>
> Thanks
> David

      reply	other threads:[~2014-04-09 19:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <534350F6.9050604@gmail.com>
2014-04-08  5:11 ` Fwd: WARNING ... drivers/gpu/drm/ttm/ttm_bo_vm.c Thomas Hellstrom
2014-04-09 18:54   ` David Herrmann
2014-04-09 19:21     ` Thomas Hellstrom [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53459DB7.7040402@vmware.com \
    --to=thellstrom@vmware.com \
    --cc=dh.herrmann@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox