From: Tomasz Stanislawski <t.stanislaws@samsung.com>
To: Joonyoung Shim <jy0922.shim@samsung.com>,
linux-samsung-soc@vger.kernel.org,
dri-devel@lists.freedesktop.org
Cc: pawel.moll@arm.com, b.zolnierkie@samsung.com,
sw0312.kim@samsung.com, kyungmin.park@samsung.com,
robh+dt@kernel.org, rahul.sharma@samsung.com,
m.chehab@samsung.com
Subject: Re: [PATCHv3 1/5] drm: exynos: hdmi: remove usage of struct s5p_hdmi_platform_data
Date: Thu, 17 Apr 2014 09:26:02 +0200 [thread overview]
Message-ID: <534F820A.4090608@samsung.com> (raw)
In-Reply-To: <534F3467.1070707@samsung.com>
Hi Joonyoung,
On 04/17/2014 03:54 AM, Joonyoung Shim wrote:
> Hi Tomasz,
>
> On 04/17/2014 12:12 AM, Tomasz Stanislawski wrote:
>> This patch continues shift of DRM EXYNOS to DT-only configuration.
>> The usage of the old structure for HDMI's platform data is
>> removed.
>>
>> Signed-off-by: Tomasz Stanislawski <t.stanislaws@samsung.com>
[snip]
>> + ret = drm_hdmi_dt_parse(hdata, dev->of_node);
>> + if (ret)
>> + return -EINVAL;
>
> It's better to return ret value.
>
I was considering return ret value. However, I preferred to
be consistent with other 'returns' which returns error literals.
Anyway, I will change it to 'return ret'.
Regards,
Tomasz Stanislawski
next prev parent reply other threads:[~2014-04-17 7:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-16 15:12 [PATCHv3 0/5] drm: exynos: update/fixes to HDMI driver Tomasz Stanislawski
2014-04-16 15:12 ` [PATCHv3 1/5] drm: exynos: hdmi: remove usage of struct s5p_hdmi_platform_data Tomasz Stanislawski
2014-04-17 1:54 ` Joonyoung Shim
2014-04-17 7:26 ` Tomasz Stanislawski [this message]
2014-04-16 15:12 ` [PATCHv3 2/5] drm: exynos: hdmi: simplify extracting hpd-gpio from DT Tomasz Stanislawski
2014-04-16 15:12 ` [PATCHv3 3/5] drm: exynos: mixer: fix using usleep() in atomic context Tomasz Stanislawski
2014-04-16 15:12 ` [PATCHv3 4/5] drm: exynos: add compatibles for HDMI and Mixer chips and exynos4210 SoC Tomasz Stanislawski
2014-04-16 15:12 ` [PATCHv3 5/5] drm: exynos: hdmi: add support for pixel clock limitation Tomasz Stanislawski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=534F820A.4090608@samsung.com \
--to=t.stanislaws@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jy0922.shim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=pawel.moll@arm.com \
--cc=rahul.sharma@samsung.com \
--cc=robh+dt@kernel.org \
--cc=sw0312.kim@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox