dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Christian König" <deathsimple@vodafone.de>
To: Alex Deucher <alexdeucher@gmail.com>, dri-devel@lists.freedesktop.org
Cc: Alex Deucher <alexander.deucher@amd.com>
Subject: Re: [PATCH] drm/radeon/aux: fix hpd assignment for aux bus
Date: Tue, 22 Apr 2014 11:17:06 +0200	[thread overview]
Message-ID: <53563392.6090003@vodafone.de> (raw)
In-Reply-To: <1398146526-9227-1-git-send-email-alexander.deucher@amd.com>

Am 22.04.2014 08:02, schrieb Alex Deucher:
> The hpd (hot plug detect) pin assignment got lost
> in the conversion to to the common i2c over aux
> code.  Without this information, aux transactions
> do not work properly.  Fixes DP failures.
>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

Added to my 3.15 queue.

Does this also fix the issue Ed Tomlinson <edt@aei.ca> reported about?

Christian.

> ---
>   drivers/gpu/drm/radeon/atombios_dp.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/radeon/atombios_dp.c b/drivers/gpu/drm/radeon/atombios_dp.c
> index 1593652..bc0119f 100644
> --- a/drivers/gpu/drm/radeon/atombios_dp.c
> +++ b/drivers/gpu/drm/radeon/atombios_dp.c
> @@ -209,6 +209,7 @@ void radeon_dp_aux_init(struct radeon_connector *radeon_connector)
>   {
>   	int ret;
>   
> +	radeon_connector->ddc_bus->rec.hpd = radeon_connector->hpd.hpd;
>   	radeon_connector->ddc_bus->aux.dev = radeon_connector->base.kdev;
>   	radeon_connector->ddc_bus->aux.transfer = radeon_dp_aux_transfer;
>   	ret = drm_dp_aux_register_i2c_bus(&radeon_connector->ddc_bus->aux);

  reply	other threads:[~2014-04-22  9:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-22  6:02 [PATCH] drm/radeon/aux: fix hpd assignment for aux bus Alex Deucher
2014-04-22  9:17 ` Christian König [this message]
2014-04-22 11:58   ` Deucher, Alexander

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53563392.6090003@vodafone.de \
    --to=deathsimple@vodafone.de \
    --cc=alexander.deucher@amd.com \
    --cc=alexdeucher@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox