From mboxrd@z Thu Jan 1 00:00:00 1970 From: Woody Suwalski Subject: Re: [git pull] drm fixes Date: Fri, 25 Apr 2014 18:12:35 -0400 Message-ID: <535ADDD3.2090006@gmail.com> References: <2619529.mEMJol0YfM@grover> <1549585.kmUPduLgev@grover> <10435496.M4aSBzoVye@grover> <5358325D.6010409@gmail.com> <5358C8B5.7020609@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <5358C8B5.7020609@amd.com> Sender: linux-kernel-owner@vger.kernel.org To: =?UTF-8?B?Q2hyaXN0aWFuIEvDtm5pZw==?= , Dave Airlie , Linus Torvalds Cc: Ed Tomlinson , Linux Kernel Mailing List , DRI mailing list List-Id: dri-devel@lists.freedesktop.org Christian K=C3=B6nig wrote: > Am 23.04.2014 23:36, schrieb Woody Suwalski: >> Dave Airlie wrote: >>> On Wed, Apr 23, 2014 at 1:59 AM, Linus Torvalds >>> wrote: >>>> Dave, mind sending me a pull request for drm fixes? >>>> >>>> There's now at least these two: >>>> >>>> - "drm/radeon/aux: fix hpd assignment for aux bus" >>>> - "drm/radeon: use fixed PPL ref divider if needed" >>>> >>>> that look like fairly fatal regressions when they affect somebody. >>>> >>>> The fact that we already had *two* independent bugs be reported wi= thin >>>> days of that last out-of-merge-window pull request makes me very >>>> unhappy with the state of drm pulls. >>>> >>>> So please make sure that future fixes really are *fixes*. For >>>> regressions only. No more games like this. >>> The pll fallout is fixes for the initial feature that was in the=20 >>> merge window, >>> Tuning plls for monitors is always a pain in the ass, the previous=20 >>> algorithm >>> took a couple of kernels a few years back to get where it was,=20 >>> unfortunately >>> HDMI came along and showed up a bunch of its shortcomings. I'm happ= y >>> Alex and Christian are on top of things in terms of tracking=20 >>> regressions >>> and making sure they get fixed, >>> >>> the AUX fix yes I'm a bit pissed off about myself, but I missed a p= ull >>> from a few >>> weeks ago, felt guilty, and maybe should have chosen the other path= =20 >>> and let it >>> wait a merge, >>> >>> Christian just sent me a -fixes pull with all of these in it and I'= ll >>> send it on to you >>> in a few mins. >>> >>> Dave. >>> >> That patch also fixes a shimmering (water floating) issue on Radeon=20 >> RV635 (Thinkpad T500) >> 1002:9591 > > Was this a long outstanding bug or a regression introduced with one o= f=20 > the recent patches? > > Thanks for the info, > Christian. Regression from 3.15-rc1 (still OK in -rc1, shimmering in -rc2) Woody