From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomasz Stanislawski Subject: Re: [PATCH 0/2] Add support for sii9234 chip Date: Mon, 05 May 2014 16:15:03 +0200 Message-ID: <53679CE7.3070202@samsung.com> References: <1397216910-15904-1-git-send-email-t.stanislaws@samsung.com> <20140503231726.GA20212@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by gabe.freedesktop.org (Postfix) with ESMTP id 4962F6E8F0 for ; Mon, 5 May 2014 07:15:19 -0700 (PDT) Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245]) by mailout2.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0N5300NB6U950YC0@mailout2.w1.samsung.com> for dri-devel@lists.freedesktop.org; Mon, 05 May 2014 15:15:05 +0100 (BST) In-reply-to: <20140503231726.GA20212@kroah.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Greg KH Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, arnd@arndb.de, linux-doc@vger.kernel.org, rdunlap@infradead.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, kyungmin.park@samsung.com, robh+dt@kernel.org, ben-linux@fluff.org, grant.likely@linaro.org, kgene.kim@samsung.com, m.szyprowski@samsung.com, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org On 05/04/2014 01:17 AM, Greg KH wrote: > On Fri, Apr 11, 2014 at 01:48:28PM +0200, Tomasz Stanislawski wrote: >> Hi everyone, >> This patchset adds support for sii9234 HD Mobile Link Bridge. The chip is used >> to convert HDMI signal into MHL. The driver enables HDMI output on Trats and >> Trats2 boards. >> >> The code is based on the driver [1] developed by: >> Adam Hampson >> Erik Gilling >> with additional contributions from: >> Shankar Bandal >> Dharam Kumar >> >> The drivers architecture was greatly simplified and transformed into a form >> accepted (hopefully) by opensource community. The main differences from >> original code are: >> * using single I2C client instead of 4 subclients >> * remove all logic non-related to establishing HDMI link >> * simplify error handling >> * rewrite state machine in interrupt handler >> * wakeup and discovery triggered by an extcon event >> * integrate with Device Tree >> >> For now, the driver is added to drivers/misc/ directory because it has neigher >> userspace nor kernel interface. The chip is capable of receiving and >> processing CEC events, so the driver may export an input device in /dev/ in the >> future. However CEC could be also handled by HDMI driver. >> >> I kindly ask for suggestions about the best location for this driver. > > It really is an extcon driver, so why not put it in drivers/extcon? And > that might solve any build issues you have if you don't select extcon in > your .config file and try to build this code :) > > thanks, Hi Greg, Thank you for your comments. As I understand, drivers/extcon contains only extcon providers. This driver is an extcon client, so mentioned location may not be adequate. I am surprised that there are no comments about this driver. Sii9234 chip is present on many exynos based boards/phones and HDMI subsystem will not work without this code. Regards, Tomasz Stanislawski > > greg k-h >