dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Andrzej Hajda <a.hajda@samsung.com>
To: YoungJun Cho <yj44.cho@samsung.com>,
	airlied@linux.ie, dri-devel@lists.freedesktop.org
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
	linux-samsung-soc@vger.kernel.org, pawel.moll@arm.com,
	ijc+devicetree@hellion.org.uk, sw0312.kim@samsung.com,
	kyungmin.park@samsung.com, robh+dt@kernel.org,
	laurent.pinchart@ideasonboard.com, galak@codeaurora.org,
	kgene.kim@samsung.com, s.trumtrar@pengutronix.de
Subject: Re: [PATCH 01/18] drm/exynos: dsi: move the EoT packets configuration point
Date: Tue, 20 May 2014 11:50:33 +0200	[thread overview]
Message-ID: <537B2569.8010805@samsung.com> (raw)
In-Reply-To: <1400048825-6052-2-git-send-email-yj44.cho@samsung.com>

On 05/14/2014 08:26 AM, YoungJun Cho wrote:
> This configuration could be used in MIPI DSI command mode also.
>
> Signed-off-by: YoungJun Cho <yj44.cho@samsung.com>
> Acked-by: Inki Dae <inki.dae@samsung.com>
> Acked-by: Kyungmin Park <kyungmin.park@samsung.com>

Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>

> ---
>  drivers/gpu/drm/exynos/exynos_drm_dsi.c |    5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
> index 84661fe..0a4e3ce 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
> @@ -473,8 +473,6 @@ static int exynos_dsi_init_link(struct exynos_dsi *dsi)
>  
>  		if (!(dsi->mode_flags & MIPI_DSI_MODE_VSYNC_FLUSH))
>  			reg |= DSIM_MFLUSH_VS;
> -		if (!(dsi->mode_flags & MIPI_DSI_MODE_EOT_PACKET))
> -			reg |= DSIM_EOT_DISABLE;
>  		if (dsi->mode_flags & MIPI_DSI_MODE_VIDEO_SYNC_PULSE)
>  			reg |= DSIM_SYNC_INFORM;
>  		if (dsi->mode_flags & MIPI_DSI_MODE_VIDEO_BURST)
> @@ -491,6 +489,9 @@ static int exynos_dsi_init_link(struct exynos_dsi *dsi)
>  			reg |= DSIM_HSA_MODE;
>  	}
>  
> +	if (!(dsi->mode_flags & MIPI_DSI_MODE_EOT_PACKET))
> +		reg |= DSIM_EOT_DISABLE;
> +
>  	switch (dsi->format) {
>  	case MIPI_DSI_FMT_RGB888:
>  		reg |= DSIM_MAIN_PIX_FORMAT_RGB888;

  reply	other threads:[~2014-05-20  9:50 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-14  6:26 [PATCH 00/18] drm/exynos: support MIPI DSI command mode display YoungJun Cho
2014-05-14  6:26 ` [PATCH 01/18] drm/exynos: dsi: move the EoT packets configuration point YoungJun Cho
2014-05-20  9:50   ` Andrzej Hajda [this message]
2014-05-14  6:26 ` [PATCH 02/18] drm/exynos: use wait_event_timeout() for safety usage YoungJun Cho
2014-05-20  9:51   ` Andrzej Hajda
2014-05-20 10:02   ` Daniel Kurtz
2014-05-21  2:18     ` YoungJun Cho
2014-05-14  6:26 ` [PATCH 03/18] ARM: dts: video: add command mode display timing DT bindings YoungJun Cho
2014-05-14  6:26 ` [PATCH 04/18] video: add command mode and command mode display timing YoungJun Cho
2014-05-14  6:26 ` [PATCH 05/18] drm_modes: add command mode helpers YoungJun Cho
2014-05-14  6:26 ` [PATCH 06/18] ARM: dts: sysreg: add exynos5 compatible to DT bindings YoungJun Cho
2014-05-14  6:26 ` [PATCH 07/18] ARM: dts: samsung-fimd: add I80 specific properties YoungJun Cho
2014-05-14  6:26 ` [PATCH 08/18] drm/exynos: add TE handler to support MIPI DSI command mode interface YoungJun Cho
2014-05-14  6:26 ` [PATCH 09/18] drm/exynos: dsi: add TE handler to support " YoungJun Cho
2014-05-14  6:26 ` [PATCH 10/18] drm/exynos: fimd: support I80 interface YoungJun Cho
2014-05-14  6:26 ` [PATCH 11/18] ARM: dts: exynos_dsim: add exynos5420 compatible to DT bindings YoungJun Cho
2014-05-14  6:26 ` [PATCH 12/18] drm/exynos: dsi: add driver data to support Exynos5420 YoungJun Cho
2014-05-14  6:27 ` [PATCH 13/18] ARM: dts: s6e3fa0: add DT bindings YoungJun Cho
2014-05-14  6:27 ` [PATCH 14/18] drm/panel: add S6E3FA0 driver YoungJun Cho
2014-05-20 10:18   ` Andrzej Hajda
2014-05-14  6:27 ` [PATCH 15/18] ARM: dts: exynos4: add system register node YoungJun Cho
2014-05-14  6:27 ` [PATCH 16/18] ARM: dts: exynos5: add system register support YoungJun Cho
2014-05-14  6:27 ` [PATCH 17/18] ARM: dts: exynos5420: add mipi-phy node YoungJun Cho
2014-05-14  6:27 ` [PATCH 18/18] ARM: dts: exynos5420: add dsi node YoungJun Cho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=537B2569.8010805@samsung.com \
    --to=a.hajda@samsung.com \
    --cc=airlied@linux.ie \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=kgene.kim@samsung.com \
    --cc=kyungmin.park@samsung.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=s.trumtrar@pengutronix.de \
    --cc=sw0312.kim@samsung.com \
    --cc=yj44.cho@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox