From: Inki Dae <inki.dae@samsung.com>
To: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2 3/3] exynos: fix scaling factor computation in g2d_copy_with_scale
Date: Fri, 13 Jun 2014 14:06:20 +0900 [thread overview]
Message-ID: <539A86CC.8080805@samsung.com> (raw)
In-Reply-To: <1401638646-4039-3-git-send-email-tjakobi@math.uni-bielefeld.de>
On 2014년 06월 02일 01:04, Tobias Jakobi wrote:
> When division of source and destination width yields the
> scaling factor for the x-coordinate, then it should be
> source/destination _height_ for y.
Signed-off-by: Inki Dae <inki.dae@samsung.com>
Thanks,
Inki Dae
>
> Signed-off-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
> ---
> exynos/exynos_fimg2d.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/exynos/exynos_fimg2d.c b/exynos/exynos_fimg2d.c
> index a565910..fc281b6 100644
> --- a/exynos/exynos_fimg2d.c
> +++ b/exynos/exynos_fimg2d.c
> @@ -451,7 +451,7 @@ int g2d_copy_with_scale(struct g2d_context *ctx, struct g2d_image *src,
> else {
> scale = 1;
> scale_x = (double)src_w / (double)dst_w;
> - scale_y = (double)src_w / (double)dst_h;
> + scale_y = (double)src_h / (double)dst_h;
> }
>
> if (src_x + src_w > src->width)
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2014-06-13 5:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-01 16:04 [PATCH v2 1/3] exynos: fix coordinate computation in g2d_copy Tobias Jakobi
2014-06-01 16:04 ` [PATCH v2 2/3] exynos: fix G2D_DOUBLE_TO_FIXED for non-integer input Tobias Jakobi
2014-06-13 5:05 ` Inki Dae
2014-06-01 16:04 ` [PATCH v2 3/3] exynos: fix scaling factor computation in g2d_copy_with_scale Tobias Jakobi
2014-06-13 5:06 ` Inki Dae [this message]
2014-06-13 5:06 ` [PATCH v2 1/3] exynos: fix coordinate computation in g2d_copy Inki Dae
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=539A86CC.8080805@samsung.com \
--to=inki.dae@samsung.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=tjakobi@math.uni-bielefeld.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox