From: Liu Ying <b17645@freescale.com>
To: Daniel Vetter <daniel@ffwll.ch>, Liu Ying <Ying.Liu@freescale.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/fb-helper: Return correct type to match drm_fb_helper_debug_enter() prototype
Date: Thu, 19 Jun 2014 15:24:07 +0800 [thread overview]
Message-ID: <53A29017.3040905@freescale.com> (raw)
In-Reply-To: <20140619070119.GN5821@phenom.ffwll.local>
On 06/19/2014 03:01 PM, Daniel Vetter wrote:
> On Thu, Jun 19, 2014 at 10:50:31AM +0800, Liu Ying wrote:
>> The return type of drm_fb_helper_debug_enter() is int, so we should return '0'
>> instead of 'false'.
>>
>> Signed-off-by: Liu Ying <Ying.Liu@freescale.com>
>> ---
>> drivers/gpu/drm/drm_fb_helper.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
>> index d5d8cea..8daa4ad 100644
>> --- a/drivers/gpu/drm/drm_fb_helper.c
>> +++ b/drivers/gpu/drm/drm_fb_helper.c
>> @@ -200,7 +200,7 @@ int drm_fb_helper_debug_enter(struct fb_info *info)
>> int i;
>>
>> if (list_empty(&kernel_fb_helper_list))
>> - return false;
>> + return 0;
>
> Actually we can remove the entire if check since list_for_each_entry is a
> no-op on an empty list, and then we'll fall right through to the return 0;
> at the end of the function. Care to respin your patch?
> -Daniel
Ok, I will respin my patch. Thanks.
Liu Ying
>
>>
>> list_for_each_entry(helper, &kernel_fb_helper_list, kernel_fb_list) {
>> for (i = 0; i < helper->crtc_count; i++) {
>> --
>> 1.7.9.5
>>
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel@lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/dri-devel
>
prev parent reply other threads:[~2014-06-19 7:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-19 2:50 [PATCH] drm/fb-helper: Return correct type to match drm_fb_helper_debug_enter() prototype Liu Ying
2014-06-19 7:01 ` Daniel Vetter
2014-06-19 7:24 ` Liu Ying [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A29017.3040905@freescale.com \
--to=b17645@freescale.com \
--cc=Ying.Liu@freescale.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox