Re: [PATCH] drm/radeon: Inline r100_mm_rreg, -wreg, v3

["Christian König" <deathsimple@vodafone.de>]

Am 10.07.2014 10:48, schrieb Lauri Kasanen:
> On Sun, 20 Apr 2014 19:41:11 +0200
> Christian König <deathsimple@vodafone.de> wrote:
>
>> Am 20.04.2014 19:29, schrieb Lauri Kasanen:
>>> This was originally un-inlined by Andi Kleen in 2011 citing size concerns.
>>> Indeed, a first attempt at inlining it grew radeon.ko by 7%.
>>>
>>> However, 2% of cpu is spent in this function. Simply inlining it gave 1% more fps
>>> in Urban Terror.
>>>
>>> v2: We know the minimum MMIO size. Adding it to the if allows the compiler to
>>> optimize the branch out, improving both performance and size.
>>>
>>> The v2 patch decreases radeon.ko size by 2%. I didn't re-benchmark, but common sense
>>> says perf is now more than 1% better.
>>>
>>> v3: Also change _wreg, make the threshold a define.
>>>
>>> Inlining _wreg increased the size a bit compared to v2, so now radeon.ko
>>> is only 1% smaller.
>>>
>>> Signed-off-by: Lauri Kasanen <cand@gmx.com>
>> Reviewed-by: Christian König <christian.koenig@amd.com>
> Ping. Although reviewed in April, seems this wasn't applied to any tree?

Sorry looks like I missed it. Alex can you pull that in your 3.17 branch?

Thanks,
Christian.

>
> - Lauri