From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maarten Lankhorst Subject: Re: [PATCH 09/17] drm/radeon: use common fence implementation for fences Date: Tue, 22 Jul 2014 16:27:01 +0200 Message-ID: <53CE74B5.3000201@canonical.com> References: <20140709093124.11354.3774.stgit@patser> <20140709122953.11354.46381.stgit@patser> <53CE2421.5040906@amd.com> <20140722114607.GL15237@phenom.ffwll.local> <20140722115737.GN15237@phenom.ffwll.local> <53CE56ED.4040109@vodafone.de> <53CE6FB0.90500@canonical.com> <53CE7410.3090603@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <53CE7410.3090603@amd.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: =?ISO-8859-1?Q?Christian_K=F6nig?= , =?ISO-8859-1?Q?Christian_K=F6nig?= , Dave Airlie , Thomas Hellstrom , nouveau , LKML , dri-devel , Ben Skeggs , "Deucher, Alexander" List-Id: dri-devel@lists.freedesktop.org op 22-07-14 16:24, Christian K=F6nig schreef: >> No, you really shouldn't be doing much in the check anyway, it's meant t= o be a lightweight check. If you're not ready yet because of a lockup simpl= y return not signaled yet. > It's not only the lockup case from radeon I have in mind here. For usersp= ace queues it might be necessary to call copy_from_user to figure out if a = fence is signaled or not. > > Returning false all the time is probably not a good idea either. Having userspace implement a fence sounds like an awful idea, why would you= want to do that? A fence could be exported to userspace, but that would only mean it can wai= t for it to be signaled with an interface like poll.. ~Maarten