From: "Christian König" <deathsimple@vodafone.de>
To: "Michel Dänzer" <michel@daenzer.net>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/radeon: fix irq ring buffer overflow handling
Date: Wed, 23 Jul 2014 12:07:02 +0200 [thread overview]
Message-ID: <53CF8946.7000504@vodafone.de> (raw)
In-Reply-To: <53CF7B65.1020704@daenzer.net>
Am 23.07.2014 11:07, schrieb Michel Dänzer:
> On 23.07.2014 16:47, Christian König wrote:
>> From: Christian König <christian.koenig@amd.com>
>>
>> We must mask out the overflow bit as well, otherwise
>> the wptr will never match the rptr again and the interrupt
>> handler will loop forever.
>>
>> Signed-off-by: Christian König <christian.koenig@amd.com>
> Reviewed-by: Michel Dänzer <michel.daenzer@amd.com>
>
>
>> Cc: stable@vger.kernel.org
> Not sure this is justified though. Were you able to reproduce the
> problem and verify the fix?
Not yet, reproducing ring buffer overflows aren't easy to do. But I've
had that multiple times with CIK and userptr support work and I can try
if I can reproduce it once more.
From reading the code it looks like a rather fundamental problem to me
and because of this I've added the stable Cc.
Christian.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2014-07-23 10:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-23 7:47 [PATCH] drm/radeon: fix irq ring buffer overflow handling Christian König
2014-07-23 9:07 ` Michel Dänzer
2014-07-23 10:07 ` Christian König [this message]
2014-07-23 15:36 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53CF8946.7000504@vodafone.de \
--to=deathsimple@vodafone.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=michel@daenzer.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox