dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Emil Velikov <emil.l.velikov@gmail.com>
To: Andreas Boll <andreas.boll.dev@gmail.com>,
	dri-devel@lists.freedesktop.org
Cc: emil.l.velikov@gmail.com
Subject: Re: [PATCH libdrm] libdrm: Fix drm.h include in qxl drm header file
Date: Mon, 28 Jul 2014 16:06:55 +0100	[thread overview]
Message-ID: <53D6670F.8040804@gmail.com> (raw)
In-Reply-To: <CACiKqBfdc+3eYBjmz2BPVFp5UKyEh4zAvxAZyUiLNkNnfXZrcg@mail.gmail.com>

On 28/07/14 15:35, Andreas Boll wrote:
> ping
> 
> 2014-05-05 23:54 GMT+02:00 Andreas Boll <andreas.boll.dev@gmail.com>:
>> Use "drm.h" instead of "drm/drm.h" as used in the other header files.
>> Fixes xserver-xorg-video-qxl build with KMS support on Debian, where this
>> file is installed in /usr/include/libdrm.
>>
I believe that's the default location for most linux distributions. Seems like
not many of us build the qxl ddx :\

FWIW
Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com>

>> Fixes Debian bug #746807
>>
>> Reported-by: Bastian Blank <waldi@debian.org>
>> Signed-off-by: Andreas Boll <andreas.boll.dev@gmail.com>
>> ---
>>  include/drm/qxl_drm.h | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/drm/qxl_drm.h b/include/drm/qxl_drm.h
>> index 5d7de70..1e331a8 100644
>> --- a/include/drm/qxl_drm.h
>> +++ b/include/drm/qxl_drm.h
>> @@ -25,7 +25,7 @@
>>  #define QXL_DRM_H
>>
>>  #include <stddef.h>
>> -#include "drm/drm.h"
>> +#include "drm.h"
>>
>>  /* Please note that modifications to all structs defined here are
>>   * subject to backwards-compatibility constraints.
>> --
>> 1.9.2
>>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
> 

  reply	other threads:[~2014-07-28 15:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-05 21:54 [PATCH libdrm] libdrm: Fix drm.h include in qxl drm header file Andreas Boll
2014-07-28 14:35 ` Andreas Boll
2014-07-28 15:06   ` Emil Velikov [this message]
2014-07-28 15:37     ` Andreas Boll

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53D6670F.8040804@gmail.com \
    --to=emil.l.velikov@gmail.com \
    --cc=andreas.boll.dev@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox