Re: [PATCH] drm: omapdrm: fix compiler errors

[Tomi Valkeinen <tomi.valkeinen@ti.com>]

[-- Attachment #1.1: Type: text/plain, Size: 2315 bytes --]

Hi Dave,

On 12/07/14 12:53, Russell King wrote:
> Regular randconfig nightly testing has detected problems with omapdrm.
> 
> omapdrm fails to build when the kernel is built to support 64-bit DMA
> addresses and/or 64-bit physical addresses due to an assumption about
> the width of these types.
> 
> Use %pad to print DMA addresses, rather than %x or %Zx (which is even
> more wrong than %x).  Avoid passing a uint32_t pointer into a function
> which expects dma_addr_t pointer.
> 
> drivers/gpu/drm/omapdrm/omap_plane.c: In function 'omap_plane_pre_apply':
> drivers/gpu/drm/omapdrm/omap_plane.c:145:2: error: format '%x' expects argument of type 'unsigned int', but argument 5 has type 'dma_addr_t' [-Werror=format]
> drivers/gpu/drm/omapdrm/omap_plane.c:145:2: error: format '%x' expects argument of type 'unsigned int', but argument 6 has type 'dma_addr_t' [-Werror=format]
> make[5]: *** [drivers/gpu/drm/omapdrm/omap_plane.o] Error 1
> drivers/gpu/drm/omapdrm/omap_gem.c: In function 'omap_gem_get_paddr':
> drivers/gpu/drm/omapdrm/omap_gem.c:794:4: error: format '%x' expects argument of type 'unsigned int', but argument 3 has type 'dma_addr_t' [-Werror=format]
> drivers/gpu/drm/omapdrm/omap_gem.c: In function 'omap_gem_describe':
> drivers/gpu/drm/omapdrm/omap_gem.c:991:4: error: format '%Zx' expects argument of type 'size_t', but argument 7 has type 'dma_addr_t' [-Werror=format]
> drivers/gpu/drm/omapdrm/omap_gem.c: In function 'omap_gem_init':
> drivers/gpu/drm/omapdrm/omap_gem.c:1470:4: error: format '%x' expects argument of type 'unsigned int', but argument 7 has type 'dma_addr_t' [-Werror=format]
> make[5]: *** [drivers/gpu/drm/omapdrm/omap_gem.o] Error 1
> drivers/gpu/drm/omapdrm/omap_dmm_tiler.c: In function 'dmm_txn_append':
> drivers/gpu/drm/omapdrm/omap_dmm_tiler.c:226:2: error: passing argument 3 of 'alloc_dma' from incompatible pointer type [-Werror]
> make[5]: *** [drivers/gpu/drm/omapdrm/omap_dmm_tiler.o] Error 1
> make[5]: Target `__build' not remade because of errors.
> make[4]: *** [drivers/gpu/drm/omapdrm] Error 2
> 
> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>

Acked-by: Tomi Valkeinen <tomi.valkeinen@ti.com>

Dave, I don't have any other patches for omapdrm for 3.17, so can you
apply this directly?

 Tomi



[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel