From mboxrd@z Thu Jan 1 00:00:00 1970 From: Emil Velikov Subject: Re: [PATCHv2 0/8] Upstreaming the Android build and misc fixes Date: Sun, 24 Aug 2014 19:39:54 +0100 Message-ID: <53FA317A.30401@gmail.com> References: <1406485557-10638-1-git-send-email-emil.l.velikov@gmail.com> <1406654843-13625-1-git-send-email-emil.l.velikov@gmail.com> <8FCC70911F3E9548866CA0E51893BCC31A1E1254@IRSMSX105.ger.corp.intel.com> <53DA8BCA.8030508@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-we0-f181.google.com (mail-we0-f181.google.com [74.125.82.181]) by gabe.freedesktop.org (Postfix) with ESMTP id 3C3616E05E for ; Sun, 24 Aug 2014 11:40:26 -0700 (PDT) Received: by mail-we0-f181.google.com with SMTP id k48so12512334wev.12 for ; Sun, 24 Aug 2014 11:40:25 -0700 (PDT) In-Reply-To: <53DA8BCA.8030508@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: "Gore, Tim" , "dri-devel@lists.freedesktop.org" Cc: emil.l.velikov@gmail.com List-Id: dri-devel@lists.freedesktop.org Hi Tim, Gave the series another try, and there was some minor issues caused by commit 5d8357976a8 (configure: Support symbol visibility when available). Did not see any of the originally mentioned issues. Are you sure that you've tried it on top of fd.o/drm/master ? Do you have any comments, would like to do any testing (note it will not work due to the mmap/mmap64 bionic issue, to be addressed next) or should I go ahead and commit the series ? Thanks Emil The series: http://lists.freedesktop.org/archives/dri-devel/2014-July/064952.html Patchv3 3/8: http://lists.freedesktop.org/archives/dri-devel/2014-August/066748.html On 31/07/14 19:32, Emil Velikov wrote: > Strange, I've explicitly made sure that it's rebased on top of libdrm/master. > I will give it another try in a moment. > > FWIW, for Intel at least a mmap/mmap64 would be needed due to the bionic > shortage of their original implementation. > > As mentioned earlier, I'm seeking for a few acked/reviewed-by and the rest of > the fixes will follow in due time. Can I consider this acked-by ? > > Thanks for having a look > -Emil > > On 31/07/14 16:33, Gore, Tim wrote: >> Ok, I still had to manually apply some of patch 3/8 as it was corrupted >> And would not apply, but after this I was able to build within one of >> My android trees. I have not tested the resulting libraries yet, but the >> Overall build process seems ok. >> >> Tim >> >>> -----Original Message----- >>> From: Emil Velikov [mailto:emil.l.velikov@gmail.com] >>> Sent: Tuesday, July 29, 2014 6:27 PM >>> To: dri-devel@lists.freedesktop.org >>> Cc: Gore, Tim >>> Subject: [PATCHv2 0/8] Upstreaming the Android build and misc fixes >>> >>> Changes since the orignal posting: >>> - Rebased on top of master. >>> - Used _H_FILES for header lists (_HEADERS is a no-go with autotools) >>> - Install the freedreno headers to {include_dir}/freedreno, similar to the >>> automake builds. >>> - Correctly include $(hw)/Android.mk >>> >>> The series is also available at the fixes+android-v2 branch in >>> https://github.com/evelikov/libdrm. >>> >>> -Emil >> >